feat: fix tc to verify the lamdba is not invoked and uses local output

Author: kevin9foong

src/app/utils/__tests__/convert-html-to-pdf.spec.ts

@@ -152,11 +152,43 @@ describe('convert-html-to-pdf', () => {
 
   // TODO: [PDF-LAMBDA-GENERATION]: Remove tests for shadowing and using the correct output based on isUseLambdaOutput once lambda is rolled out
   describe('generatePdfFromHtml', () => {
-    it('should use lambda output when isUseLambdaOutput is true and not use local output', async () => {
+    beforeEach(() => {
+      AwsConfig.pdfGeneratorLambda.invoke = jest.fn()
+    })
+    it('should not invoke lambda and just return local output when AwsConfig.pdfGeneratorLambdaFunctionName is empty', async () => {
+      // Arrange
+      const mockLocalBuffer = Buffer.from('local pdf content')
+      AwsConfig.pdfGeneratorLambdaFunctionName = ''
+
+      // Mock local response
+      const mockPage = {
+        setContent: jest.fn(),
+        pdf: jest.fn().mockResolvedValue(mockLocalBuffer),
+      }
+      const mockBrowser = {
+        newPage: jest.fn().mockResolvedValue(mockPage),
+        close: jest.fn(),
+      }
+      ;(puppeteer.launch as jest.Mock).mockResolvedValue(mockBrowser)
+
+      // Act
+      const result = await generatePdfFromHtml(MOCK_HTML, true)
+
+      // Assert
+      expect(result).toEqual(mockLocalBuffer)
+      expect(AwsConfig.pdfGeneratorLambda.invoke).not.toHaveBeenCalled()
+    })
+
+    it('should use lambda output when isUseLambdaOutput is true and not use local output and AwsConfig.pdfGeneratorLambdaFunctionName is defined', async () => {
       // Arrange
       const mockLambdaBuffer = Buffer.from('lambda pdf content')
       const mockLocalBuffer = Buffer.from('local pdf content')
 
+      const DUMMY_PDF_GENERATOR_FUNCTION_NAME =
+        'dummy-pdf-generator-function-name'
+      AwsConfig.pdfGeneratorLambdaFunctionName =
+        DUMMY_PDF_GENERATOR_FUNCTION_NAME
+
       // Mock lambda response
       const mockLambdaResponse = {
         Payload: JSON.stringify({
@@ -188,16 +220,21 @@ describe('convert-html-to-pdf', () => {
 
       // Verify the lambda invocation parameters
       expect(AwsConfig.pdfGeneratorLambda.invoke).toHaveBeenCalledWith({
-        FunctionName: AwsConfig.pdfGeneratorLambdaFunctionName,
+        FunctionName: DUMMY_PDF_GENERATOR_FUNCTION_NAME,
         Payload: JSON.stringify({ html: MOCK_HTML }),
       })
     })
 
-    it('should use local output when isUseLambdaOutput is false and not use lambda output', async () => {
+    it('should use local output when isUseLambdaOutput is false and not use lambda output and AwsConfig.pdfGeneratorLambdaFunctionName is defined', async () => {
       // Arrange
       const mockLambdaBuffer = Buffer.from('lambda pdf content')
       const mockLocalBuffer = Buffer.from('local pdf content')
 
+      const DUMMY_PDF_GENERATOR_FUNCTION_NAME =
+        'dummy-pdf-generator-function-name'
+      AwsConfig.pdfGeneratorLambdaFunctionName =
+        DUMMY_PDF_GENERATOR_FUNCTION_NAME
+
       // Mock lambda response
       const mockLambdaResponse = {
         Payload: JSON.stringify({
@@ -228,7 +265,7 @@ describe('convert-html-to-pdf', () => {
       expect(result).not.toEqual(mockLambdaBuffer)
     })
 
-    it('should generate PDFs using both methods in parallel regardless of isUseLambdaOutput setting', async () => {
+    it('should generate PDFs using both methods in parallel regardless of isUseLambdaOutput setting if AwsConfig.pdfGeneratorLambdaFunctionName is defined', async () => {
       // Arrange
       const mockLambdaBuffer = Buffer.from('lambda pdf content')
       const mockLocalBuffer = Buffer.from('local pdf content')
@@ -240,6 +277,12 @@ describe('convert-html-to-pdf', () => {
           body: mockLambdaBuffer.toString('base64'),
         }),
       }
+
+      // Mock AWS config to ensure lambda function name is defined
+      const DUMMY_PDF_GENERATOR_FUNCTION_NAME =
+        'dummy-pdf-generator-function-name'
+      AwsConfig.pdfGeneratorLambdaFunctionName =
+        DUMMY_PDF_GENERATOR_FUNCTION_NAME
       ;(AwsConfig.pdfGeneratorLambda.invoke as jest.Mock)
         .mockResolvedValueOnce(mockLambdaResponse)
         .mockResolvedValueOnce(mockLambdaResponse)
@@ -269,7 +312,7 @@ describe('convert-html-to-pdf', () => {
 
       // Verify the lambda invocation parameters
       expect(AwsConfig.pdfGeneratorLambda.invoke).toHaveBeenCalledWith({
-        FunctionName: AwsConfig.pdfGeneratorLambdaFunctionName,
+        FunctionName: DUMMY_PDF_GENERATOR_FUNCTION_NAME,
         Payload: JSON.stringify({ html: MOCK_HTML }),
       })
     })