fix: lint and fix sp tc

Author: kevin9foong

src/app/modules/form/admin-form/__tests__/admin-form.controller.spec.ts

@@ -462,6 +462,7 @@ export class MyInfoServiceClass {
     return Result.fromThrowable(
       () => jwt.verify(loginJwt, spcpMyInfoConfig.myInfoJwtSecret),
       (error) => {
+        console.log('xxx4', error)
         logger.error({
           message: 'Error while verifying MyInfo login cookie',
           meta: {
@@ -475,6 +476,7 @@ export class MyInfoServiceClass {
       if (isMyInfoLoginCookie(decoded)) {
         return ok(decoded)
       }
+      console.log('xxx3', decoded)
       return err(new MyInfoInvalidLoginCookieError())
     })
   }

src/app/modules/myinfo/myinfo.service.ts

@@ -242,7 +242,7 @@ export const performPaymentPostSubmissionActions = (
                 performEncryptPostSubmissionActions({
                   submission,
                   responses: payment.responses,
-                  emailFields: [], // TODO [EMAIL-CONFIRMATION-BUG]: Email confirmation email to email fields does not work for payment forms, this is an existing issue to be fixed.  
+                  emailFields: [], // TODO [EMAIL-CONFIRMATION-BUG]: Email confirmation email to email fields does not work for payment forms, this is an existing issue to be fixed.
                 })
                   .andThen(() =>
                     // If successfully sent email confirmations, delete response data from payment document.

src/app/modules/payments/payments.service.ts

@@ -668,7 +668,7 @@ describe('submission.service', () => {
         submissionAttachments: MOCK_ATTACHMENTS,
         pdfAttachment: undefined,
         isPaymentEnabled: false,
-        responsesData: undefined,
+        responsesData: [],
       })
 
       const expectedAutoReplyData = [

src/app/modules/submission/__tests__/submission.service.spec.ts

@@ -165,22 +165,14 @@ describe('encrypt-submission.service', () => {
 
           expect(
             MockMailService.sendSubmissionToAdmin.mock.calls[0][0].formData,
-          ).toEqual(
-            expect.arrayContaining([
-              expect.objectContaining({
-                answer: MOCK_NRIC,
-                fieldType: BasicField.Nric,
-                isVisible: true,
-                question: SgidFieldTitle.SgidNric,
-              }),
-            ]),
-          )
-
-          // Does not contain any other fields
-          expect(
-            MockMailService.sendSubmissionToAdmin.mock.calls[0][0].formData
-              .length,
-          ).toEqual(1)
+          ).toEqual([
+            {
+              answer: MOCK_NRIC,
+              fieldType: BasicField.Nric,
+              answerTemplate: [MOCK_NRIC],
+              question: SgidFieldTitle.SgidNric,
+            },
+          ])
         })
       })
 

src/app/modules/submission/encrypt-submission/__tests__/encrypt-submission.service.spec.ts

@@ -197,6 +197,7 @@ const submitEncryptModeForm = async (
     }
     case FormAuthType.SGID_MyInfo:
     case FormAuthType.MyInfo: {
+      console.log('xxx', req.cookies)
       const jwtPayloadResult = await extractMyInfoLoginJwt(
         req.cookies,
         authType,
@@ -206,6 +207,7 @@ const submitEncryptModeForm = async (
           return uinFin
         })
         .mapErr((error) => {
+          console.log('xxx2', error)
           logger.error({
             message: `Error verifying MyInfo${
               authType === FormAuthType.SGID_MyInfo ? '(over SGID)' : ''

src/app/modules/submission/encrypt-submission/encrypt-submission.controller.ts

@@ -3,13 +3,6 @@ import mongoose from 'mongoose'
 import { err, ok, okAsync, Result, ResultAsync } from 'neverthrow'
 import Mail from 'nodemailer/lib/mailer'
 
-import { AutoreplyPdfGenerationError } from '../../../services/mail/mail.errors'
-import {
-  AutoReplyMailData,
-  AutoreplySummaryRenderData,
-} from '../../../services/mail/mail.types'
-import { generateAutoreplyPdf } from '../../../services/mail/mail.utils'
-
 import {
   DateString,
   FormResponseMode,
@@ -26,7 +19,13 @@ import {
 import config from '../../../config/config'
 import { createLoggerWithLabel } from '../../../config/logger'
 import { getEncryptSubmissionModel } from '../../../models/submission.server.model'
+import { AutoreplyPdfGenerationError } from '../../../services/mail/mail.errors'
 import MailService from '../../../services/mail/mail.service'
+import {
+  AutoReplyMailData,
+  AutoreplySummaryRenderData,
+} from '../../../services/mail/mail.types'
+import { generateAutoreplyPdf } from '../../../services/mail/mail.utils'
 import { createQueryWithDateParam } from '../../../utils/date'
 import { getMongoErrorMessage } from '../../../utils/handle-mongo-error'
 import { DatabaseError, PossibleDatabaseError } from '../../core/core.errors'

src/app/modules/submission/encrypt-submission/encrypt-submission.service.ts

@@ -13,10 +13,6 @@ import {
 } from 'lodash'
 import mongoose from 'mongoose'
 import { err, ok, Result } from 'neverthrow'
-import { handleAddressResponseDisplay } from '../../../../shared/utils/address'
-import { SIGNATURE_CAPTURED_STRING } from '../../../../shared/utils/signature'
-
-import { convertToSignaturePngDataUri } from '../../utils/convert-vector-array-to-png'
 
 import {
   CLIENT_CHECKBOX_OTHERS_INPUT_VALUE,
@@ -41,7 +37,9 @@ import {
   SubmittedStep,
   WorkflowStatus,
 } from '../../../../shared/types'
+import { handleAddressResponseDisplay } from '../../../../shared/utils/address'
 import * as FileValidation from '../../../../shared/utils/file-validation'
+import { SIGNATURE_CAPTURED_STRING } from '../../../../shared/utils/signature'
 import {
   EmailRespondentConfirmationField,
   FieldResponse,
@@ -83,6 +81,7 @@ import {
   VerifyTurnstileError,
 } from '../../services/turnstile/turnstile.errors'
 import { CreatePresignedPostError } from '../../utils/aws-s3'
+import { convertToSignaturePngDataUri } from '../../utils/convert-vector-array-to-png'
 import { genericMapRouteErrorTransform } from '../../utils/error'
 import {
   DatabaseConflictError,