fix: myinfo children missing prefix (#8916)

* draft changes with console logs for testing

* revamped logging for debugging

* revert children dev code change

* added childName to responseId

* updated getMyInfoPrefix function to check for child ids

* revert path update on FE component

* added formatMyInfoStorageResponseTests, removed console testing logs

* removed remaining debugging logs

* reverted middleware functions changed to support debugging logs

Author: scottheng96

src/app/modules/submission/encrypt-submission/__tests__/encrypt-submission.utils.spec.ts

@@ -6,6 +6,7 @@ import { IPopulatedEncryptedForm, StorageModeSubmissionData } from 'src/types'
 
 import {
   createStorageModeSubmissionDto,
+  formatMyInfoStorageResponseData,
   getPaymentAmount,
   getPaymentIntentDescription,
 } from '../encrypt-submission.utils'
@@ -150,4 +151,80 @@ describe('encrypt-submission.utils', () => {
       expect(result).toContain(expectedValue)
     })
   })
+
+  describe('formatMyInfoStorageResponseData', () => {
+    it('should return original responses when no hashed fields are provided', () => {
+      // Arrange
+      const parsedResponses: any[] = [
+        { _id: 'field1', question: 'Question 1' },
+        { _id: 'field2', question: 'Question 2' },
+      ]
+
+      // Act
+      const actual = formatMyInfoStorageResponseData(parsedResponses)
+
+      // Assert
+      expect(actual).toEqual(parsedResponses)
+    })
+
+    it('should prefix MyInfo fields in responses when hashed fields are provided', () => {
+      // Arrange
+      const parsedResponses: any[] = [
+        {
+          _id: 'field1',
+          question: 'Question 1',
+          myInfo: { attr: 'NAME' },
+          answer: 'John Doe',
+          fieldType: 'textfield',
+        },
+        {
+          _id: 'field2',
+          question: 'Question 2',
+          answer: 'Some answer',
+          fieldType: 'textfield',
+        },
+        {
+          _id: 'childrenbirthrecords.692411846d1da146b503aada.childname.0',
+          question: 'Question Child',
+          myInfo: { attr: 'childname' },
+          answer: 'Child Name',
+          fieldType: 'children',
+        },
+      ]
+      const hashedFields = new Set([
+        'field1',
+        'childrenbirthrecords.692411846d1da146b503aada.childname.0',
+      ])
+
+      // Act
+      const actual = formatMyInfoStorageResponseData(
+        parsedResponses,
+        hashedFields,
+      )
+
+      // Assert
+      expect(actual).toEqual([
+        {
+          _id: 'field1',
+          question: '[MyInfo] Question 1',
+          myInfo: { attr: 'NAME' },
+          answer: 'John Doe',
+          fieldType: 'textfield',
+        },
+        {
+          _id: 'field2',
+          question: 'Question 2',
+          answer: 'Some answer',
+          fieldType: 'textfield',
+        },
+        {
+          _id: 'childrenbirthrecords.692411846d1da146b503aada.childname.0',
+          question: '[MyInfo] Question Child',
+          myInfo: { attr: 'childname' },
+          answer: 'Child Name',
+          fieldType: 'children',
+        },
+      ])
+    })
+  })
 })

src/app/modules/submission/submission.utils.ts

@@ -776,7 +776,15 @@ export const getMyInfoPrefix = (
   response: ResponseFormattedForEmail | ProcessedFieldResponse,
   hashedFields: Set<MyInfoKey>,
 ): string => {
-  return !!response.myInfo?.attr && hashedFields.has(response._id)
+  /* encrypt mode children fields have ids e.g. childrenbirthrecords.67585515e1ced6d790a91e14.childname.0
+   * without the suffixed child name. So we check if any hashed fields starts with response id
+   */
+  const isResponseMyInfoChildren =
+    response.fieldType === BasicField.Children &&
+    Array.from(hashedFields).some((field) => field.startsWith(response._id))
+
+  return !!response.myInfo?.attr &&
+    (hashedFields.has(response._id) || isResponseMyInfoChildren)
     ? MYINFO_PREFIX
     : ''
 }