Skip to content

Conversation

@kevin9foong
Copy link
Contributor

@kevin9foong kevin9foong commented Dec 5, 2025

Problem

Pdf rendering requires transformation of data to a specific format, which is duplicated across mrf and storage mode. This duplication can be removed.

Solution

Encapsulate the pdf rendering to within the pdf generation function itself, reducing the chances of inconsistencies in pdf data format across form modes.

Breaking Changes

No - this PR is backwards compatible

Tests

TC1: PDF copy generated correctly for MRF with signature field

  • Create an MRF with signature field and a bunch of other fields (table, short text etc)
  • Add an email field with respondent copy PDF.
  • Submit the form.
  • Assert that the respondent email is received with correct PDF details (note the date format, form name, submission id and fields and their answers are correct)

TC1: PDF copy generated correctly for Storage mode with signature field

  • Create an storage mode with signature field and a bunch of other fields (table, short text etc)
  • Add an email field with respondent copy PDF.
  • Submit the form.
  • Assert that the respondent email is received with correct PDF details (note the date format, form name, submission id and fields and their answers are correct)

@kevin9foong kevin9foong requested a review from a team as a code owner December 5, 2025 10:08
@kevin9foong kevin9foong changed the base branch from develop to chore/remove-gb-from-payments-functions December 5, 2025 10:08
@kevin9foong kevin9foong self-assigned this Dec 5, 2025
@kevin9foong kevin9foong force-pushed the feat/encapsulate-pdf-data-formatting branch 6 times, most recently from a2bcfef to 5d426d0 Compare December 5, 2025 13:43
@kevin9foong kevin9foong force-pushed the feat/encapsulate-pdf-data-formatting branch from 5d426d0 to e1d68d2 Compare December 5, 2025 13:51
Base automatically changed from chore/remove-gb-from-payments-functions to develop December 8, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants