feat: encapsulate data pdf formatting #8948
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Pdf rendering requires transformation of data to a specific format, which is duplicated across mrf and storage mode. This duplication can be removed.
Solution
Encapsulate the pdf rendering to within the pdf generation function itself, reducing the chances of inconsistencies in pdf data format across form modes.
Breaking Changes
No - this PR is backwards compatible
Tests
TC1: PDF copy generated correctly for MRF with signature field
TC1: PDF copy generated correctly for Storage mode with signature field