test(redirect): update RedirectService tests to reflect direct redirect behavior for ogUrl matches

Author: adriangohjw

src/server/modules/redirect/services/__tests__/RedirectService.test.ts

@@ -8,12 +8,14 @@ import { RedirectType } from '../..'
 const ogUrl = 'https://go.gov.sg'
 
 // Mock the config module
-jest.mock('../../../../config', () => ({
-  logger: {
-    warn: jest.fn(),
-  },
-  ogUrl,
-}))
+jest.mock('../../../../config', () => {
+  return {
+    logger: {
+      warn: jest.fn(),
+    },
+    ogUrl: 'https://go.gov.sg',
+  }
+})
 
 // Mock dependencies
 const mockUrlRepository = {
@@ -58,37 +60,37 @@ describe('RedirectService', () => {
   })
 
   describe('referrer validation', () => {
-    it('should show transition page for exact ogUrl match when user has not visited before', async () => {
+    it('should allow direct redirect for exact ogUrl match when user has not visited before', async () => {
       const result = await redirectService.redirectFor(
         'test',
         undefined,
         'Mozilla/5.0',
         ogUrl,
       )
 
-      expect(result.redirectType).toBe(RedirectType.TransitionPage)
+      expect(result.redirectType).toBe(RedirectType.Direct)
     })
 
-    it('should show transition page for ogUrl with path when user has not visited before', async () => {
+    it('should allow direct redirect for ogUrl with path when user has not visited before', async () => {
       const result = await redirectService.redirectFor(
         'test',
         undefined,
         'Mozilla/5.0',
         `${ogUrl}/some-path`,
       )
 
-      expect(result.redirectType).toBe(RedirectType.TransitionPage)
+      expect(result.redirectType).toBe(RedirectType.Direct)
     })
 
-    it('should show transition page for ogUrl with query params when user has not visited before', async () => {
+    it('should allow direct redirect for ogUrl with query params when user has not visited before', async () => {
       const result = await redirectService.redirectFor(
         'test',
         undefined,
         'Mozilla/5.0',
         `${ogUrl}?param=value`,
       )
 
-      expect(result.redirectType).toBe(RedirectType.TransitionPage)
+      expect(result.redirectType).toBe(RedirectType.Direct)
     })
 
     it('should show transition page for ogUrl with different protocol when user has not visited before', async () => {