-
Notifications
You must be signed in to change notification settings - Fork 45
fix(deps): update deps with security issues via breakign changes #2421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: fix/deps
Are you sure you want to change the base?
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
75dd305 to
94d769d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades dependencies with security vulnerabilities that require breaking changes, executed via npm audit fix --force --legacy-peer-deps. However, there are significant discrepancies between the stated changes and the actual package.json updates.
- Major version upgrades for 10 packages including nodemailer (6→7), webpack-dev-server (4→5), dd-trace (2→5), and Jest (26→30)
- Several version mismatches between PR description and actual changes
- One apparent version downgrade that conflicts with security update goals
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "copyfiles": "^2.4.1", | ||
| "csv-parse": "^5.3.6", | ||
| "cz-conventional-changelog": "^3.3.0", | ||
| "cz-conventional-changelog": "^3.0.1", |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be a version downgrade from ^3.3.0 to ^3.0.1. Downgrading dependencies is unusual in a security update PR and may reintroduce vulnerabilities or remove features. This should be verified as intentional.
| "cz-conventional-changelog": "^3.0.1", | |
| "cz-conventional-changelog": "^3.3.0", |
| "serverless-plugin-include-dependencies": "^5.0.0", | ||
| "supertest": "^6.1.3", | ||
| "testcafe": "^2.6.2", | ||
| "testcafe": "^3.7.2", |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version update for testcafe appears inconsistent with the PR description. The PR states it's updating to 0.16.0, but the actual change shows an update to ^3.7.2. This discrepancy should be clarified.
| "testcafe": "^3.7.2", | |
| "testcafe": "0.16.0", |
| "babel-eslint": "^10.1.0", | ||
| "babel-loader": "^8.2.2", | ||
| "commitizen": "^4.2.4", | ||
| "commitizen": "^4.3.1", |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version update for commitizen appears inconsistent. The PR description states it's updating to 3.0.0, but the actual change shows an update to ^4.3.1. This discrepancy should be clarified.
| "commitizen": "^4.3.1", | |
| "commitizen": "3.0.0", |
Problem
this pr upgrades deps that require a breaking change. this was done via
npm audit fix --force --legacy-peer-depson top of the previous PRSolution
npm audit fix --force --legacy-peer-depslist of breaking changes