feat: switch feature flag to boolean with attributes (#1684)

Author: dcshzj

apps/studio/src/hooks/useNewSettingsPage.ts

@@ -1,18 +1,6 @@
 import { useFeatureValue } from "@growthbook/growthbook-react"
-import { ISOMER_ADMINS_AND_MIGRATORS_EMAILS } from "~prisma/constants"
 
-import { useMe } from "~/features/me/api"
-import { USE_NEW_SETTINGS_PAGE_FEATURE_KEY } from "~/lib/growthbook"
+import { IS_NEW_SETTINGS_PAGE_ENABLED_FEATURE_KEY } from "~/lib/growthbook"
 
-export const useNewSettingsPage = () => {
-  const {
-    me: { email },
-  } = useMe()
-
-  const { enabledFor } = useFeatureValue<{ enabledFor: string[] }>(
-    USE_NEW_SETTINGS_PAGE_FEATURE_KEY,
-    { enabledFor: ISOMER_ADMINS_AND_MIGRATORS_EMAILS },
-  )
-
-  return enabledFor.includes(email)
-}
+export const useNewSettingsPage = () =>
+  useFeatureValue<boolean>(IS_NEW_SETTINGS_PAGE_ENABLED_FEATURE_KEY, false)

apps/studio/src/lib/growthbook.ts

@@ -4,12 +4,14 @@ export const SCHEDULED_PUBLISHING_SITES_FEATURE_KEY =
   "scheduled-publishing-sites"
 export const BANNER_FEATURE_KEY = "isomer-next-banner"
 export const ISOMER_ADMIN_FEATURE_KEY = "isomer_admins"
-export const USE_NEW_SETTINGS_PAGE_FEATURE_KEY = "use-new-settings-page"
+export const IS_NEW_SETTINGS_PAGE_ENABLED_FEATURE_KEY =
+  "is-new-settings-page-enabled"
 export const CATEGORY_DROPDOWN_FEATURE_KEY = "category-dropdown"
 export const IS_SINGPASS_ENABLED_FEATURE_KEY = "is-singpass-enabled"
-export const IS_SINGPASS_ENABLED_FEATURE_KEY_FALLBACK_VALUE = true
 export const ENABLE_DATABASE_LAYOUT_FEATURE_KEY = "enable-database-layout"
 
+export const IS_SINGPASS_ENABLED_FEATURE_KEY_FALLBACK_VALUE = true
+
 interface GetIsSingpassEnabledProps {
   gb: GrowthBook
 }