Skip to content

Commit 69c314b

Browse files
authored
Enhancement - collection tagfilters first (#973)
* make 'others' a const * extract into consts * extract into getYearFilters * extract getCategoryFilters * add correct types * extract getTagFilters * rename to singular * move logic into each get*Filter function to improve readability * fix import * remove type renaming during import * refactor imports location * refactor: standardize code structure * only return filters with at least 2 items * add storybook * reorder collection filters to put "tags" first * do not render "category" if there's no category filter * remove shouldShowCategory * resolve merge * resolve merge
1 parent ec7e344 commit 69c314b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

packages/components/src/templates/next/layouts/Collection/utils/getAvailableFilters.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,10 @@ import { getYearFilter } from "./getYearFilter"
77
export const getAvailableFilters = (
88
items: ProcessedCollectionCardProps[],
99
): Filter[] => {
10+
// TODO: Allow user to pass in order of filters to be shown
1011
return [
12+
...getTagFilters(items),
1113
getCategoryFilter(items),
1214
getYearFilter(items),
13-
...getTagFilters(items),
1415
].filter((filter) => filter.items.length >= 1)
1516
}

0 commit comments

Comments
 (0)