donotmerge: temp disable flag for bugbash

Author: kevinkim-ogp

packages/backend/src/graphql/__tests__/mutations/upsert-flow-collaborator.itest.ts

@@ -1,5 +1,6 @@
 import { randomUUID } from 'crypto'
-import { beforeEach, describe, expect, it, vi } from 'vitest'
+// import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { beforeEach, describe, expect, it } from 'vitest'
 
 import { BadUserInputError } from '@/errors/graphql-errors'
 import upsertFlowCollaborator from '@/graphql/mutations/upsert-flow-collaborator'
@@ -15,13 +16,13 @@ import Context from '@/types/express/context'
 
 import { generateMockContext } from './tiles/table.mock'
 
-const mocks = vi.hoisted(() => ({
-  getLdFlagValue: vi.fn().mockResolvedValue(true),
-}))
+// const mocks = vi.hoisted(() => ({
+//   getLdFlagValue: vi.fn().mockResolvedValue(true),
+// }))
 
-vi.mock('@/helpers/launch-darkly', () => ({
-  getLdFlagValue: mocks.getLdFlagValue,
-}))
+// vi.mock('@/helpers/launch-darkly', () => ({
+//   getLdFlagValue: mocks.getLdFlagValue,
+// }))
 
 describe('upsert flow collaborator', () => {
   let context: Context
@@ -649,16 +650,16 @@ describe('upsert flow collaborator', () => {
     })
   })
 
-  it('should not allow adding collaborators if collaborators flag is false', async () => {
-    mocks.getLdFlagValue.mockResolvedValue(false)
-    await expect(
-      upsertFlowCollaborator(
-        null,
-        {
-          input: { flowId: dummyFlow.id, email: editor.email, role: 'editor' },
-        },
-        context,
-      ),
-    ).rejects.toThrow(BadUserInputError)
-  })
+  // it('should not allow adding collaborators if collaborators flag is false', async () => {
+  //   mocks.getLdFlagValue.mockResolvedValue(false)
+  //   await expect(
+  //     upsertFlowCollaborator(
+  //       null,
+  //       {
+  //         input: { flowId: dummyFlow.id, email: editor.email, role: 'editor' },
+  //       },
+  //       context,
+  //     ),
+  //   ).rejects.toThrow(BadUserInputError)
+  // })
 })

packages/backend/src/graphql/mutations/upsert-flow-collaborator.ts

@@ -5,7 +5,7 @@ import { addFlowTableConnection } from '@/helpers/add-flow-connection'
 import { getOrCreateUser } from '@/helpers/auth'
 import { validateAndParseEmail } from '@/helpers/email-validator'
 import { getConnectionDetails } from '@/helpers/get-shared-connection-details'
-import { getLdFlagValue } from '@/helpers/launch-darkly'
+// import { getLdFlagValue } from '@/helpers/launch-darkly'
 import logger from '@/helpers/logger'
 import Flow from '@/models/flow'
 import FlowCollaborator from '@/models/flow-collaborators'
@@ -22,14 +22,14 @@ const upsertFlowCollaborator: MutationResolvers['upsertFlowCollaborator'] =
     }
 
     // TODO (kevinkim-ogp): remove this once collaborators is released to all
-    const collaboratorsFlag = await getLdFlagValue(
-      'collaborators',
-      context.currentUser.email,
-      false,
-    )
-    if (!collaboratorsFlag) {
-      throw new BadUserInputError(' You are not allowed to add collaborators.')
-    }
+    // const collaboratorsFlag = await getLdFlagValue(
+    //   'collaborators',
+    //   context.currentUser.email,
+    //   false,
+    // )
+    // if (!collaboratorsFlag) {
+    //   throw new BadUserInputError(' You are not allowed to add collaborators.')
+    // }
 
     const validatedEmail = await validateAndParseEmail(email)
     if (!validatedEmail) {