Release v1.56.1 (#1331)

hotfix: old pipes dont have notificationRecipients

Author: kevinkim-ogp

package-lock.json

@@ -111,5 +111,5 @@
     "tsconfig-paths": "^4.2.0",
     "type-fest": "4.10.3"
   },
-  "version": "1.56.0"
+  "version": "1.56.1"
 }

packages/backend/package.json

@@ -3,7 +3,10 @@ import sortBy from 'lodash/sortBy'
 import { TEMPLATES } from '@/db/storage'
 import FlowCollaborator from '@/models/flow-collaborators'
 
-import type { Resolvers } from '../__generated__/types.generated'
+import type {
+  FlowErrorConfigResolvers,
+  Resolvers,
+} from '../__generated__/types.generated'
 
 type FlowResolver = Resolvers['Flow']
 
@@ -46,6 +49,20 @@ const role: FlowResolver['role'] = async (parent) => {
   return (parent as any)?.role || 'viewer'
 }
 
+// in collaborators, we introduced the concept of notificationRecipients,
+// which is an array that may contain 'editor' and/or 'viewer'.
+// however, there may be existing flows that already have errorConfig.notificationFrequency
+// and when returning, may not contain this `notificationRecipients` field
+// to avoid gql errors, we force it to return an empty array
+const notificationRecipients: FlowErrorConfigResolvers['notificationRecipients'] =
+  (parent) => {
+    return parent?.notificationRecipients ?? []
+  }
+
+export const FlowErrorConfig: FlowErrorConfigResolvers = {
+  notificationRecipients,
+}
+
 export default {
   template,
   collaborators,

packages/backend/src/graphql/custom-resolvers/flow.ts

@@ -1,5 +1,5 @@
 import ExecutionStep from './execution-step'
-import Flow from './flow'
+import Flow, { FlowErrorConfig } from './flow'
 import FlowCollaborator from './flow-collaborator'
 import TableMetadata from './table-metadata'
 
@@ -14,4 +14,10 @@ import TableMetadata from './table-metadata'
  * schema.gql-to-typescript.ts.
  */
 
-export default { ExecutionStep, TableMetadata, Flow, FlowCollaborator }
+export default {
+  ExecutionStep,
+  TableMetadata,
+  Flow,
+  FlowCollaborator,
+  FlowErrorConfig,
+}

packages/backend/src/graphql/custom-resolvers/index.ts

@@ -1,6 +1,6 @@
 {
   "name": "frontend",
-  "version": "1.56.0",
+  "version": "1.56.1",
   "type": "module",
   "scripts": {
     "dev": "wait-on tcp:3000 && vite --host --force",

packages/frontend/package.json

@@ -1,6 +1,6 @@
 import { NotificationRecipients } from '@plumber/types'
 
-import { useCallback, useContext } from 'react'
+import { useCallback, useContext, useMemo } from 'react'
 import { Controller, useFormContext } from 'react-hook-form'
 import { useMutation } from '@apollo/client'
 import { Flex, FormControl, Skeleton, Stack, Text } from '@chakra-ui/react'
@@ -119,11 +119,14 @@ export default function Notifications() {
   const [updateFlowConfig] = useMutation(UPDATE_FLOW_CONFIG)
   const toast = useToast()
 
-  const defaultValues = {
-    frequency,
-    editor: notificationRecipients.includes(Recipient.Editor),
-    viewer: notificationRecipients.includes(Recipient.Viewer),
-  }
+  const defaultValues = useMemo(
+    () => ({
+      frequency,
+      editor: notificationRecipients.includes(Recipient.Editor),
+      viewer: notificationRecipients.includes(Recipient.Viewer),
+    }),
+    [frequency, notificationRecipients],
+  )
 
   const onFlowConfigUpdate = useCallback(
     async (

packages/frontend/src/components/EditorSettings/Notifications.tsx

@@ -2,5 +2,5 @@
   "name": "@plumber/types",
   "description": "Shared types for plumber",
   "types": "./index.d.ts",
-  "version": "1.56.0"
+  "version": "1.56.1"
 }