chore: remove GetStepWithTestExecutions and ExecuteFlow, remove single step testing killswitch

Author: pregnantboy

packages/backend/src/graphql/mutation-resolvers.ts

@@ -10,7 +10,6 @@ import deleteFlow from './mutations/delete-flow'
 import deleteStep from './mutations/delete-step'
 import deleteUploadedFile from './mutations/delete-uploaded-file'
 import duplicateFlow from './mutations/duplicate-flow'
-import executeFlow from './mutations/execute-flow'
 import executeStep from './mutations/execute-step'
 import generateAuthUrl from './mutations/generate-auth-url'
 import generatePresignedUrl from './mutations/generate-presigned-url'
@@ -63,7 +62,6 @@ export default {
   updateFlow,
   updateFlowStatus,
   updateFlowConfig,
-  executeFlow,
   executeStep,
   deleteFlow,
   createStep,

packages/backend/src/graphql/mutations/execute-flow.ts

@@ -7,7 +7,7 @@ const getTestExecutionSteps: QueryResolvers['getTestExecutionSteps'] = async (
   params,
   context,
 ) => {
-  const { flowId, ignoreTestExecutionId } = params
+  const { flowId } = params
   // For checking if flow belongs to the user
   const flow = await context.currentUser
     .$relatedQuery('flows')
@@ -17,10 +17,7 @@ const getTestExecutionSteps: QueryResolvers['getTestExecutionSteps'] = async (
     .findById(flowId)
     .throwIfNotFound()
 
-  const testExecutionSteps = await getTestExecutionStepsHelper(
-    flow.id,
-    ignoreTestExecutionId,
-  )
+  const testExecutionSteps = await getTestExecutionStepsHelper(flow.id)
 
   // We do not return test execution steps if the step is not complete
   // to ensure we dont show variables from other step/events.

packages/backend/src/graphql/queries/get-step-with-test-executions.ts

@@ -12,7 +12,6 @@ import getFlowTransferDetails from './queries/get-flow-transfer-details'
 import getFlows from './queries/get-flows'
 import getPendingFlowTransfers from './queries/get-pending-flow-transfers'
 import getPlumberStats from './queries/get-plumber-stats'
-import getStepWithTestExecutions from './queries/get-step-with-test-executions'
 import getTemplates from './queries/get-templates'
 import getTestExecutionSteps from './queries/get-test-execution-steps'
 import healthcheck from './queries/healthcheck'
@@ -37,7 +36,6 @@ export default {
   testConnection,
   getFlow,
   getFlows,
-  getStepWithTestExecutions,
   getTestExecutionSteps,
   getExecution,
   getExecutions,

packages/backend/src/graphql/queries/get-test-execution-steps.ts

@@ -15,8 +15,6 @@ type Query {
     connectionId: String
     name: String
   ): PaginatedFlows
-  getStepWithTestExecutions(stepId: String!): [Step]
-    @deprecated(reason: "Use getTestExecution instead")
   getTestExecutionSteps(
     flowId: String!
     ignoreTestExecutionId: Boolean
@@ -77,7 +75,6 @@ type Mutation {
   updateFlow(input: UpdateFlowInput): Flow
   updateFlowStatus(input: UpdateFlowStatusInput): Flow
   updateFlowConfig(input: UpdateFlowConfigInput): Flow
-  executeFlow(input: ExecuteFlowInput): ExecutionStep!
   executeStep(input: ExecuteStepInput): ExecutionStep!
   deleteFlow(input: DeleteFlowInput): Boolean
   createStep(input: CreateStepInput): Step
@@ -476,10 +473,6 @@ input UpdateFlowConfigInput {
   attachments: [FlowAttachmentsConfigInput]
 }
 
-input ExecuteFlowInput {
-  stepId: String!
-}
-
 input ExecuteStepInput {
   stepId: String!
 }

packages/backend/src/graphql/query-resolvers.ts

@@ -5,7 +5,6 @@ import Flow from '@/models/flow'
 
 export async function getTestExecutionSteps(
   flowId: string,
-  ignoreTestExecutionId = false,
 ): Promise<ExecutionStep[]> {
   const flow = await Flow.query()
     .findById(flowId)
@@ -23,7 +22,7 @@ export async function getTestExecutionSteps(
     return []
   }
 
-  if (flow.testExecution && !ignoreTestExecutionId) {
+  if (flow.testExecution) {
     const testExecutionSteps = flow.testExecution.executionSteps
 
     /**

packages/backend/src/graphql/schema.graphql

@@ -7,8 +7,6 @@
 export const BANNER_TEXT_FLAG = 'banner_display'
 // we only want to show this notification to users created before this date (ms since epoch)
 export const SINGLE_STEP_TEST_SHOW_BEFORE_FLAG = 'single_step_test_show_before'
-// kill-switch for single-step testing in case of issues
-export const SINGLE_STEP_TEST_KILL_SWITCH = 'single_step_test_kill_switch'
 
 /**
  * Feature flags

packages/backend/src/helpers/get-test-execution-steps.ts

@@ -1,13 +1,6 @@
 import type { IApp, IExecutionStep, IFlow, IStep } from '@plumber/types'
 
-import {
-  createContext,
-  ReactNode,
-  useCallback,
-  useContext,
-  useMemo,
-  useState,
-} from 'react'
+import { createContext, ReactNode, useCallback, useMemo, useState } from 'react'
 import { useMutation, useQuery } from '@apollo/client'
 import { Center, useDisclosure } from '@chakra-ui/react'
 import { useIsMobile } from '@opengovsg/design-system-react'
@@ -17,11 +10,9 @@ import {
   genVariableInfoMap,
   VariableInfoMap,
 } from '@/components/RichTextEditor/utils'
-import { SINGLE_STEP_TEST_KILL_SWITCH } from '@/config/flags'
 import { ExecutionStep } from '@/graphql/__generated__/graphql'
 import client from '@/graphql/client'
 import { CREATE_STEP } from '@/graphql/mutations/create-step'
-import { EXECUTE_FLOW } from '@/graphql/mutations/execute-flow'
 import { EXECUTE_STEP } from '@/graphql/mutations/execute-step'
 import { UPDATE_STEP } from '@/graphql/mutations/update-step'
 import { GET_APPS } from '@/graphql/queries/get-apps'
@@ -34,8 +25,6 @@ import {
 } from '@/helpers/toolbox'
 import { extractVariables, StepWithVariables } from '@/helpers/variables'
 
-import { LaunchDarklyContext } from './LaunchDarkly'
-
 interface IEditorContextValue {
   flow: IFlow
   flowId: string
@@ -156,10 +145,6 @@ export const EditorProvider = ({
   setShouldWarnOnLeave,
   children,
 }: EditorProviderProps) => {
-  // TODO: remove this kill switch once Single Step Testing is stable
-  const { flags } = useContext(LaunchDarklyContext)
-  const shouldUseSingleStepTest = !flags?.[SINGLE_STEP_TEST_KILL_SWITCH]
-
   const isMobile = useIsMobile()
 
   const flowId = flow.id
@@ -184,8 +169,6 @@ export const EditorProvider = ({
     {
       variables: {
         flowId,
-        // ignore test execution id and fetch execution steps by ordering if SST not enabled
-        ignoreTestExecutionId: !shouldUseSingleStepTest,
       },
     },
   )
@@ -324,17 +307,15 @@ export const EditorProvider = ({
    * Test execution step
    */
   const [executeStep, { loading: isTestExecuting }] = useMutation(
-    shouldUseSingleStepTest ? EXECUTE_STEP : EXECUTE_FLOW,
+    EXECUTE_STEP,
     {
       context: { autoSnackbar: false },
       awaitRefetchQueries: true,
       refetchQueries: [GET_TEST_EXECUTION_STEPS, GET_FLOW],
       update(cache, { data }) {
         // If last execution step is successful, it means the test run is successful
         // Update the step status to completed without refreshing
-        const lastExecutionStep: ExecutionStep = shouldUseSingleStepTest
-          ? data?.executeStep
-          : data?.executeFlow
+        const lastExecutionStep: ExecutionStep = data?.executeStep
         if (lastExecutionStep.status === 'success') {
           const stepCache = cache.identify({
             __typename: 'Step',