feat: store last test submission date for frontend rendering

Author: pregnantboy

packages/backend/src/apps/formsg/__tests__/triggers/new-submission.test.ts

@@ -100,20 +100,25 @@ describe('new submission trigger', () => {
         raw: mockData,
         meta: {
           internalId: '',
+          isMock: true,
+          lastTestSubmissionDate: undefined,
         },
-        isMock: true,
       })
     })
 
     it('should use mock data if preferMock is true even though there is past submission', async () => {
-      getLastExecutionStepMock.mockResolvedValue({ dataOut: actualData })
+      getLastExecutionStepMock.mockResolvedValue({
+        dataOut: actualData,
+        createdAt: '2025-06-16 07:06:30.155+00',
+      })
       await trigger.testRun($, { preferMock: true })
       expect(pushTriggerItemMock).toHaveBeenCalledWith({
         raw: mockData,
         meta: {
           internalId: '',
+          isMock: true,
+          lastTestSubmissionDate: '2025-06-16 07:06:30.155+00',
         },
-        isMock: true,
       })
     })
 
@@ -124,32 +129,41 @@ describe('new submission trigger', () => {
         raw: mockData,
         meta: {
           internalId: '',
+          isMock: true,
+          lastTestSubmissionDate: undefined,
         },
-        isMock: true,
       })
     })
 
     it('should use last test submission if testRunMetadata is undefined and there is past submission', async () => {
-      getLastExecutionStepMock.mockResolvedValue({ dataOut: actualData })
+      getLastExecutionStepMock.mockResolvedValue({
+        dataOut: actualData,
+        createdAt: '2025-06-16 07:06:30.155+00',
+      })
       await trigger.testRun($, undefined)
       expect(pushTriggerItemMock).toHaveBeenCalledWith({
         raw: actualData,
         meta: {
           internalId: '',
+          isMock: false,
+          lastTestSubmissionDate: '2025-06-16 07:06:30.155+00',
         },
-        isMock: false,
       })
     })
 
     it('should use last test submission if preferMock is false and there is past submission', async () => {
-      getLastExecutionStepMock.mockResolvedValue({ dataOut: actualData })
+      getLastExecutionStepMock.mockResolvedValue({
+        dataOut: actualData,
+        createdAt: '2025-06-16 07:06:30.155+00',
+      })
       await trigger.testRun($, { preferMock: false })
       expect(pushTriggerItemMock).toHaveBeenCalledWith({
         raw: actualData,
         meta: {
           internalId: '',
+          isMock: false,
+          lastTestSubmissionDate: '2025-06-16 07:06:30.155+00',
         },
-        isMock: false,
       })
     })
 
@@ -160,8 +174,9 @@ describe('new submission trigger', () => {
         raw: mockData,
         meta: {
           internalId: '',
+          isMock: true,
+          lastTestSubmissionDate: undefined,
         },
-        isMock: true,
       })
     })
   })

packages/backend/src/graphql/schema.graphql

@@ -320,6 +320,7 @@ type ExecutionStep {
 
 type ExecutionStepMetadata {
   isMock: Boolean
+  lastTestSubmissionDate: String
 }
 
 type Field {

packages/backend/src/models/execution-step.ts

@@ -41,6 +41,10 @@ class ExecutionStep extends Base {
           isMock: {
             type: 'boolean',
           },
+          // this is purely used to tell frontend that there is a past test submission
+          lastTestSubmissionDate: {
+            type: 'string',
+          },
         },
       },
     },

packages/backend/src/services/trigger.ts

@@ -79,6 +79,9 @@ export const processTrigger = async (options: ProcessTriggerOptions) => {
     ...(error && { status: 'failure' }),
   })
 
+  // We store all metadata except internalId
+  const { internalId: _, ...metadataToStore } = triggerItem?.meta ?? {}
+
   const executionStep = await execution
     .$relatedQuery('executionSteps')
     .insertAndFetch({
@@ -88,7 +91,7 @@ export const processTrigger = async (options: ProcessTriggerOptions) => {
       dataOut: !error ? triggerItem?.raw : null,
       errorDetails: error,
       appKey: step.appKey,
-      metadata: triggerItem?.isMock ? { isMock: true } : {},
+      metadata: metadataToStore ?? {},
     })
 
   return {

packages/types/index.d.ts

@@ -121,6 +121,7 @@ export interface IExecutionStep {
 
 export interface IExecutionStepMetadata {
   isMock?: boolean
+  lastTestSubmissionDate?: string
 }
 
 export interface IExecution {
@@ -627,8 +628,8 @@ export interface ITriggerItem {
   raw: IJSONObject
   meta: {
     internalId: string
+    [key: string]: unknown
   }
-  isMock?: boolean
 }
 
 export type ITriggerInstructions = Partial<{