Release v1.40.3 (#971)

## Fixes
- Remove deleted column keys when updating row
- Dedupe multiple CC repeated emails

Author: m0nggh

package-lock.json

@@ -106,5 +106,5 @@
     "tsconfig-paths": "^4.2.0",
     "type-fest": "4.10.3"
   },
-  "version": "1.40.2"
+  "version": "1.40.3"
 }

packages/backend/package.json

@@ -134,15 +134,26 @@ describe('postman transactional email schema zod validation', () => {
     expect(result.data.body).toBe('hello<br>hihi')
   })
 
-  it('should validate multiple valid CC emails', () => {
+  it('should validate and lowercase multiple valid CC emails', () => {
     validPayload.destinationEmailCc =
       '[email protected], [email protected],[email protected]'
     const result = transactionalEmailSchema.safeParse(validPayload)
     assert(result.success === true) // using assert here for type assertion
     expect(result.data.destinationEmailCc).toEqual([
-      '[email protected]',
-      '[email protected]',
-      '[email protected]',
+      '[email protected]',
+      '[email protected]',
+      '[email protected]',
+    ])
+  })
+
+  it('should dedupe repeated multiple valid CC emails', () => {
+    validPayload.destinationEmailCc =
+      '[email protected], [email protected],[email protected]'
+    const result = transactionalEmailSchema.safeParse(validPayload)
+    assert(result.success === true) // using assert here for type assertion
+    expect(result.data.destinationEmailCc).toEqual([
+      '[email protected]',
+      '[email protected]',
     ])
   })
 

packages/backend/src/apps/postman/__tests__/common/parameters.test.ts

@@ -9,7 +9,7 @@ import { parseS3Id } from '@/helpers/s3'
 function recipientStringToArray(value: string) {
   const recipientArray = value
     .split(',')
-    .map((e) => e.trim())
+    .map((e) => e.trim().toLowerCase())
     .filter((e) => e?.length > 0)
   // dedupe the array
   return uniq(recipientArray)

packages/backend/src/apps/postman/common/parameters.ts

@@ -1,6 +1,6 @@
 {
   "name": "frontend",
-  "version": "1.40.2",
+  "version": "1.40.3",
   "scripts": {
     "dev": "wait-on tcp:3000 && vite --host --force",
     "build": "tsc && vite build --mode=${VITE_MODE:-prod}",

packages/frontend/package.json

@@ -82,7 +82,7 @@ export default function SuggestionsWrapper(props: SuggestionsWrapperProps) {
 
       {/* Right Panel --> Data Selector */}
       <Box flexGrow={1} w="50%">
-        <PanelHeader>{headers.left}</PanelHeader>
+        <PanelHeader>{headers.right}</PanelHeader>
         <Divider borderColor="base.divider.medium" />
         {rightPanel}
       </Box>

packages/frontend/src/components/SuggestionsWrapper/index.tsx

@@ -10,6 +10,17 @@ export const cacheConfig = {
     App: {
       keyFields: ['key'],
     },
+    // prevent apollo client from complaining about cache data loss
+    // for use when updating table (columns/names/etc)
+    TableMetadata: {
+      fields: {
+        columns: {
+          merge(_existing = [], incoming: any[]) {
+            return incoming // Replace existing with incoming
+          },
+        },
+      },
+    },
     Mutation: {
       mutationType: true,
       fields: {

packages/frontend/src/graphql/cache.ts

@@ -21,7 +21,7 @@ interface UpdateRowOutput {
 export function useUpdateRow(
   setData: Dispatch<SetStateAction<GenericRowData[]>>,
 ) {
-  const { tableId } = useTableContext()
+  const { tableId, tableColumns } = useTableContext()
   const [rowsUpdating, setRowsUpdating] = useState<Record<string, boolean>>({})
 
   const [updateRowMutation] = useMutation<UpdateRowOutput, UpdateRowInput>(
@@ -45,6 +45,12 @@ export function useUpdateRow(
   const updateRow = useCallback(
     async (updatedRow: GenericRowData) => {
       const { rowId, ...data } = updatedRow
+      // delete keys from data that are not in the table (recently deleted columns)
+      Object.keys(data).forEach((key) => {
+        if (!tableColumns.some((column) => column.id === key)) {
+          delete data[key]
+        }
+      })
       setRowsUpdating((oldState) => {
         oldState[rowId] = true
         return { ...oldState }
@@ -64,7 +70,7 @@ export function useUpdateRow(
         },
       })
     },
-    [setData, tableId, updateRowMutation],
+    [setData, tableId, tableColumns, updateRowMutation],
   )
   return {
     rowsUpdating,

packages/frontend/src/pages/Tile/hooks/useUpdateRow.tsx

@@ -4,6 +4,7 @@ import { useCallback, useState } from 'react'
 import { useMutation } from '@apollo/client'
 import { type SetOptional } from 'type-fest'
 
+import { UpdateTableMutation } from '@/graphql/__generated__/graphql'
 import { UPDATE_TABLE } from '@/graphql/mutations/tiles/update-table'
 import { GET_TABLE } from '@/graphql/queries/tiles/get-table'
 
@@ -22,18 +23,14 @@ interface UpdateTableInput {
   }
 }
 
-interface UpdateTableOutput {
-  createRow: string
-}
-
 export function useUpdateTable() {
   const { tableId } = useTableContext()
   const [isUpdatingTableName, setIsUpdatingTableName] = useState(false)
   const [isCreatingColumns, setIsCreatingColumns] = useState(false)
   const [isUpdatingColumns, setIsUpdatingColumns] = useState(false)
   const [isDeletingColumns, setIsDeletingColumns] = useState(false)
 
-  const [updateTable] = useMutation<UpdateTableOutput, UpdateTableInput>(
+  const [updateTable] = useMutation<UpdateTableMutation, UpdateTableInput>(
     UPDATE_TABLE,
     {
       awaitRefetchQueries: true,

packages/frontend/src/pages/Tile/hooks/useUpdateTable.tsx

@@ -2,5 +2,5 @@
   "name": "@plumber/types",
   "description": "Shared types for plumber",
   "types": "./index.d.ts",
-  "version": "1.40.2"
+  "version": "1.40.3"
 }