remove more vault related stuff

Author: m0nggh

packages/backend/src/apps/vault-workspace/index.ts

@@ -2,14 +2,11 @@ import { IApp } from '@plumber/types'
 
 import actions from './actions'
 
-const WORKSPACE_BASEURL =
-  'https://jcxk888grj.execute-api.ap-southeast-1.amazonaws.com'
-
 const app: IApp = {
   name: 'Vault Workspace',
   key: 'vault-workspace',
-  baseUrl: WORKSPACE_BASEURL,
-  apiBaseUrl: WORKSPACE_BASEURL,
+  baseUrl: '',
+  apiBaseUrl: '',
   iconUrl: '{BASE_URL}/apps/vault-workspace/assets/favicon.svg',
   authDocUrl:
     'https://guide.plumber.gov.sg/user-guides/actions/vault-workspace',

packages/backend/src/controllers/webhooks/handler.ts

@@ -74,10 +74,7 @@ export default async (request: IRequest, response: Response) => {
   const triggerStep = await flow.getTriggerStep()
   const triggerCommand = await triggerStep.getTriggerCommand()
   const app = await triggerStep.getApp()
-  const isWebhookApp =
-    app.key === 'webhook' ||
-    app.key === 'formsg' ||
-    app.key === 'vault-workspace'
+  const isWebhookApp = app.key === 'webhook' || app.key === 'formsg'
 
   // Allow all webhook test runs to work
   if (testRun && !isWebhookApp) {

packages/backend/src/helpers/__tests__/compute-parameters.test.ts

@@ -278,28 +278,6 @@ describe('compute parameters', () => {
       ],
     })
   })
-  it('can compute on templates with non-hex-encoded param keys using new vault WS objects whose keys hex-encoded', () => {
-    const vaultWSExecutionStep = [
-      {
-        stepId: randomStepID,
-        appKey: vaultWorkspace.key,
-        dataOut: {
-          '4974732d612d6d65': 'Mario!', // key is hex-encoded `Its a me`
-          _metadata: {
-            keysEncoded: true,
-          },
-        },
-      } as unknown as ExecutionStep,
-    ]
-    const params = {
-      toSubstitute: `Its a me {{step.${randomStepID}.Its-a-me}}`,
-    }
-    const expected = {
-      toSubstitute: 'Its a me Mario!',
-    }
-    const result = computeParameters(params, vaultWSExecutionStep)
-    expect(result).toEqual(expected)
-  })
 
   it('should work with space separated keys', () => {
     const vaultWSExecutionStep = [

packages/backend/src/helpers/compute-parameters.ts

@@ -1,8 +1,7 @@
-import { IAction, IJSONObject } from '@plumber/types'
+import type { IAction } from '@plumber/types'
 
 import get from 'lodash.get'
 
-import vaultWorkspace from '@/apps/vault-workspace'
 import ExecutionStep from '@/models/execution-step'
 
 import Step from '../models/step'
@@ -63,24 +62,8 @@ function findAndSubstituteVariables(
         const data = executionStep?.dataOut
 
         const keyPath = keyPaths.join('.') // for lodash get to work
-        let dataValue = get(data, keyPath)
-        // custom logic to deal with backward compatibility of key encoding for
-        // data from vault. Under the new logic, data from vault will always have
-        // hex-encoded key while the old templates might still used non-encoded
-        // hence if the value is not defined and keysEncoded flag was set, we
-        // attempt to convert the template string to use hex-encoded key
-        // FIXME: Remove this custom logic after we migrate off Vault WS
-        if (
-          dataValue === undefined &&
-          executionStep?.appKey === vaultWorkspace.key &&
-          (data?._metadata as IJSONObject)?.keysEncoded &&
-          keyPaths.length > 0
-        ) {
-          keyPaths[keyPaths.length - 1] = Buffer.from(
-            keyPaths[keyPaths.length - 1],
-          ).toString('hex')
-          dataValue = get(data, keyPaths.join('.'))
-        }
+        const dataValue = get(data, keyPath)
+
         // NOTE: dataValue could be an array if it is not processed on variables.ts
         // which is the case for formSG checkbox only, this is to deal with forEach next time
         return preprocessVariable