Skip to content

Commit 531c736

Browse files
authored
PLU-362: remove duplicate text in dropdowns (#795)
## Problem Dropdown options showing unnecessary values. Closes [PLU-362: remove-duplicate-text-in-dropdowns](https://linear.app/ogp/issue/PLU-362/remove-duplicate-text-in-dropdowns) ## Solution Set showOptionValue to false to hide duplicate text in dropdown ## Before & After Screenshots **BEFORE**: - Delay <img width="852" alt="Screenshot 2024-11-14 at 9 51 42 AM" src="https://github.com/user-attachments/assets/93fa8f63-e6fc-4140-bec4-5fe33f73715f"> - Scheduler <img width="858" alt="Screenshot 2024-11-14 at 9 52 45 AM" src="https://github.com/user-attachments/assets/0955e01a-ec4d-4009-9efe-f499041dfb73"> <img width="856" alt="Screenshot 2024-11-14 at 9 53 15 AM" src="https://github.com/user-attachments/assets/154b833c-0bd9-42e2-ae82-912415746a57"> <img width="851" alt="Screenshot 2024-11-14 at 9 54 26 AM" src="https://github.com/user-attachments/assets/4d09d46c-83b9-4c4a-b7b0-f2ed76dcf5ed"> - Slack <img width="856" alt="Screenshot 2024-11-14 at 9 50 42 AM" src="https://github.com/user-attachments/assets/125a819a-3d8b-47c2-b8c1-1220b49fbdfd"> <img width="853" alt="Screenshot 2024-11-14 at 9 50 55 AM" src="https://github.com/user-attachments/assets/5b64fe29-82ab-452f-b935-ccc264349a53"> **AFTER**: - Delay <img width="852" alt="Screenshot 2024-11-14 at 9 51 56 AM" src="https://github.com/user-attachments/assets/5fa9cc62-ab02-4c78-a77d-2a002f126a12"> - Scheduler <img width="855" alt="Screenshot 2024-11-14 at 9 52 57 AM" src="https://github.com/user-attachments/assets/14b02873-e97f-4614-87c2-76a0ebf783de"> <img width="855" alt="Screenshot 2024-11-14 at 9 53 29 AM" src="https://github.com/user-attachments/assets/93813d20-e9af-454c-976b-c12494100b2e"> <img width="855" alt="Screenshot 2024-11-14 at 9 54 53 AM" src="https://github.com/user-attachments/assets/3c06e1a0-e461-409b-9b4c-537f3d1a9267"> - Slack <img width="857" alt="Screenshot 2024-11-14 at 9 49 43 AM" src="https://github.com/user-attachments/assets/a33c2480-506d-4eff-865f-2f1d57a25c27"> <img width="856" alt="Screenshot 2024-11-14 at 9 49 53 AM" src="https://github.com/user-attachments/assets/d14eab37-d7bc-4dbd-8775-694ac55bc197"> ## Tests - [x] Action values saved correctly - [x] Existing steps show the correct options
1 parent da136da commit 531c736

File tree

5 files changed

+8
-0
lines changed

5 files changed

+8
-0
lines changed

packages/backend/src/apps/delay/actions/delay-for/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ const action: IRawAction = {
1616
value: null,
1717
description: 'Delay for unit, e.g. minutes, hours, days, weeks.',
1818
variables: false,
19+
showOptionValue: false,
1920
options: [
2021
{
2122
label: 'Minutes',

packages/backend/src/apps/scheduler/triggers/every-day/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ const trigger: IRawTrigger = {
3838
required: true,
3939
value: null,
4040
variables: false,
41+
showOptionValue: false,
4142
options: [
4243
{
4344
label: '00:00',

packages/backend/src/apps/scheduler/triggers/every-month/index.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ const trigger: IRawTrigger = {
2121
required: true,
2222
value: null,
2323
variables: false,
24+
showOptionValue: false,
2425
options: [
2526
{
2627
label: '1',
@@ -156,6 +157,7 @@ const trigger: IRawTrigger = {
156157
required: true,
157158
value: null,
158159
variables: false,
160+
showOptionValue: false,
159161
options: [
160162
{
161163
label: '00:00',

packages/backend/src/apps/scheduler/triggers/every-week/index.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ const trigger: IRawTrigger = {
2121
required: true,
2222
value: null,
2323
variables: false,
24+
showOptionValue: false,
2425
options: [
2526
{
2627
label: 'Monday',
@@ -60,6 +61,7 @@ const trigger: IRawTrigger = {
6061
required: true,
6162
value: null,
6263
variables: false,
64+
showOptionValue: false,
6365
options: [
6466
{
6567
label: '00:00',

packages/backend/src/apps/slack/actions/find-message/index.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ const action: IRawAction = {
2525
required: true,
2626
value: 'score',
2727
variables: false,
28+
showOptionValue: false,
2829
options: [
2930
{
3031
label: 'Match strength',
@@ -45,6 +46,7 @@ const action: IRawAction = {
4546
required: true,
4647
value: 'desc',
4748
variables: false,
49+
showOptionValue: false,
4850
options: [
4951
{
5052
label: 'Descending (newest or best match first)',

0 commit comments

Comments
 (0)