Skip to content

Commit 63b1a17

Browse files
committed
fix: cursor flagged bugs
1 parent e557b33 commit 63b1a17

File tree

4 files changed

+10
-7
lines changed

4 files changed

+10
-7
lines changed

packages/backend/src/apps/tiles/__tests__/actions/find-single-row.itest.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import {
1111
} from '@/graphql/__tests__/mutations/tiles/table.mock'
1212
import TableColumnMetadata from '@/models/table-column-metadata'
1313
import TableMetadata from '@/models/table-metadata'
14-
import { createTableRow } from '@/models/tiles/dynamodb/table-row'
1514
import * as ddbTableRowFunctions from '@/models/tiles/dynamodb/table-row/functions'
15+
import { getTableOperations } from '@/models/tiles/factory'
1616
import * as pgTableRowFunctions from '@/models/tiles/pg/table-row-functions'
1717
import { DatabaseType, TableRowFilter } from '@/models/tiles/types'
1818
import User from '@/models/user'
@@ -70,7 +70,8 @@ describe.each([['ddb'], ['pg']])(
7070
columnIds: dummyColumnIds,
7171
})
7272

73-
await createTableRow({
73+
const tableOperations = getTableOperations(databaseType)
74+
await tableOperations.createTableRow({
7475
tableId: dummyTable.id,
7576
data: originalData,
7677
})

packages/backend/src/apps/tiles/__tests__/actions/update-row.itest.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import {
1111
} from '@/graphql/__tests__/mutations/tiles/table.mock'
1212
import TableColumnMetadata from '@/models/table-column-metadata'
1313
import TableMetadata from '@/models/table-metadata'
14-
import { createTableRow } from '@/models/tiles/dynamodb/table-row'
1514
import { getTableOperations } from '@/models/tiles/factory'
1615
import { DatabaseType } from '@/models/tiles/types'
1716
import User from '@/models/user'
@@ -51,7 +50,8 @@ describe.each([['ddb'], ['pg']])(
5150
columnIds: dummyColumnIds,
5251
})
5352

54-
const rowToUpdate = await createTableRow({
53+
const tableOperations = getTableOperations(databaseType)
54+
const rowToUpdate = await tableOperations.createTableRow({
5555
tableId: dummyTable.id,
5656
data: originalData,
5757
})

packages/backend/src/graphql/__tests__/queries/tiles/table-row.mock.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,14 @@ export async function insertMockTableRows(
1919

2020
const tableOperations = getTableOperations(databaseType)
2121
const chunks = chunk(rows, 100)
22+
const rowIds = []
2223
for (const dataArray of chunks) {
23-
await tableOperations.createTableRows({
24+
const addedRowsIds = await tableOperations.createTableRows({
2425
tableId,
2526
dataArray,
2627
})
28+
rowIds.push(...addedRowsIds)
2729
}
2830

29-
return rows.map((r) => r.rowId)
31+
return rowIds
3032
}

packages/backend/test/tiles-pg-global-setup.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export async function setup() {
1919

2020
process.env.TILES_POSTGRES_PORT = postgresContainer.getPort().toString()
2121
console.info(
22-
`Tiles PostgreSQL container started at port ${process.env.POSTGRES_PORT}`,
22+
`Tiles PostgreSQL container started at port ${process.env.TILES_POSTGRES_PORT}`,
2323
)
2424
}
2525

0 commit comments

Comments
 (0)