Skip to content

Commit 8204a2e

Browse files
authored
fix: only throw multipart error if error (#1297)
thanks for finding the fix @kevinkim-ogp !
1 parent a26ae28 commit 8204a2e

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

packages/backend/src/routes/webhooks.ts

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import logger from '@/helpers/logger'
1515
const router = Router()
1616
const uploadNone = multer().none()
1717

18-
router.use((req, res, _next) => {
18+
router.use((req, res, next) => {
1919
uploadNone(req, res, (err) => {
2020
// file upload is not supported
2121
// handle error to prevent http 500 error
@@ -32,7 +32,19 @@ router.use((req, res, _next) => {
3232
res.status(415).send('Invalid request, file upload is not supported.')
3333
return
3434
}
35-
res.status(400).send('Invalid multipart data')
35+
if (err) {
36+
logger.error({
37+
req: {
38+
body: req.body,
39+
headers: req.headers,
40+
url: req.url,
41+
},
42+
err,
43+
msg: 'Invalid request: multipart error',
44+
})
45+
return res.status(400).send('Invalid multipart data')
46+
}
47+
next()
3648
})
3749
})
3850

0 commit comments

Comments
 (0)