Release v1.50.3 (#1168)

## Changes
- Step changes now updates flow's `updated_at` column
- Show (View Tile) button in editor
- Fix executions pages step count
- Backwards compatibility for sgID to MyInfo migration in FormSG

---------

Co-authored-by: kevin <[email protected]>

Author: pregnantboy

package-lock.json

@@ -109,5 +109,5 @@
     "tsconfig-paths": "^4.2.0",
     "type-fest": "4.10.3"
   },
-  "version": "1.50.2"
+  "version": "1.50.3"
 }

packages/backend/package.json

@@ -279,7 +279,6 @@ describe('decrypt form response', () => {
           ],
           verified: {
             uinFin: 'S1234567A',
-            sgidUinFin: 'S2345678B',
             cpUid: 'U987654323PLUMBER',
           },
         })
@@ -313,7 +312,7 @@ describe('decrypt form response', () => {
             },
             verifiedSubmitterInfo: {
               uinFin: 'S1234567A',
-              sgidUinFin: 'S2345678B',
+              sgidUinFin: 'S1234567A',
               cpUid: 'U987654323PLUMBER',
             },
           }),
@@ -371,7 +370,7 @@ describe('decrypt form response', () => {
             },
             verifiedSubmitterInfo: {
               uinFin: 'Z1cImQNbDXdmOaeS2roacWNxH7MbJC75OiEeYOjSbRo=',
-              sgidUinFin: 'UAM3XbFrbNVVuD9Phz3KV/roZj4aG/Ql3Ap5Y5dTtJ4=',
+              sgidUinFin: 'Z1cImQNbDXdmOaeS2roacWNxH7MbJC75OiEeYOjSbRo=',
               cpUid: 'U987654323PLUMBER',
             },
           }),
@@ -407,7 +406,7 @@ describe('decrypt form response', () => {
             },
             verifiedSubmitterInfo: {
               uinFin: 'xxxxx567A',
-              sgidUinFin: 'xxxxx678B',
+              sgidUinFin: 'xxxxx567A',
               cpUid: 'U987654323PLUMBER',
             },
           }),
@@ -426,7 +425,6 @@ describe('decrypt form response', () => {
           },
         ],
         verified: {
-          sgidUinFin: 'S1234567A',
           uinFin: '12345678B',
           cpUid: 'U987654323PLUMBER',
           cpUen: '987654321Z',
@@ -438,7 +436,7 @@ describe('decrypt form response', () => {
       expect($.request.body).toEqual(
         expect.objectContaining({
           verifiedSubmitterInfo: {
-            sgidUinFin: 'S1234567A',
+            sgidUinFin: '12345678B',
             uinFin: '12345678B',
             cpUid: 'U987654323PLUMBER',
             cpUen: '987654321Z',

packages/backend/src/apps/formsg/__tests__/auth/decrypt-form-response.test.ts

@@ -189,6 +189,10 @@ export async function decryptFormResponse(
         }
 
         verifiedSubmitterInfo[key] = value
+        // for backwards compatibility with old forms that were created with sgID authType
+        if (key === 'uinFin') {
+          verifiedSubmitterInfo['sgidUinFin'] = value
+        }
       }
     }
 

packages/backend/src/apps/formsg/auth/decrypt-form-response.ts

@@ -222,7 +222,10 @@ function buildAnswerArrayMetadatum(
 function buildVerifiedSubmitterInfoMetadata(
   data: IJSONObject,
 ): IDataOutMetadata | null {
-  if (!data.verifiedSubmitterInfo) {
+  if (
+    !data.verifiedSubmitterInfo ||
+    typeof data.verifiedSubmitterInfo !== 'object'
+  ) {
     return null
   }
 
@@ -234,7 +237,10 @@ function buildVerifiedSubmitterInfoMetadata(
         metadata.uinFin = { label: 'NRIC/FIN (Verified)' }
         break
       case 'sgidUinFin':
-        metadata.sgidUinFin = { label: 'NRIC/FIN (Verified)' }
+        metadata.sgidUinFin = {
+          label: 'NRIC/FIN (Verified)',
+          isHiddenFromList: 'uinFin' in data.verifiedSubmitterInfo,
+        }
         break
       case 'cpUid':
         metadata.cpUid = { label: 'CorpPass UID (Verified)' }

packages/backend/src/apps/formsg/triggers/new-submission/get-data-out-metadata.ts

@@ -40,18 +40,16 @@ function generateVerifiedSubmitterInfoData(
 ): Record<string, Record<string, string>> {
   const filteredNric = filterNric($, MOCK_NRIC)
   switch (authType) {
-    case 'SGID':
-    case 'SGID_MyInfo':
-      return {
-        verifiedSubmitterInfo: {
-          sgidUinFin: filteredNric,
-        },
-      }
-    case 'SP':
+    case 'SGID': // deprecated
+    case 'SGID_MyInfo': // deprecated
+    case 'SP': // deprecated
     case 'MyInfo':
+      // for backwards compatibility with old forms that were created with sgID authType,
+      // we need to return both uinFin and sgidUinFin
       return {
         verifiedSubmitterInfo: {
           uinFin: filteredNric,
+          sgidUinFin: filteredNric,
         },
       }
     case 'CP':

packages/backend/src/apps/formsg/triggers/new-submission/get-mock-data.ts

@@ -20,6 +20,10 @@ const action: IRawAction = {
       type: 'dropdown' as const,
       required: true,
       variables: false,
+      clickableLink: {
+        label: 'View tile',
+        url: '/tiles/{value}',
+      },
       showOptionValue: false,
       addNewOption: {
         id: 'tiles-createTileRow-tableId',

packages/backend/src/apps/tiles/actions/create-row/index.ts

@@ -31,6 +31,10 @@ const action: IRawAction = {
       required: true,
       variables: false,
       showOptionValue: false,
+      clickableLink: {
+        label: 'View tile',
+        url: '/tiles/{value}',
+      },
       source: {
         type: 'query' as const,
         name: 'getDynamicData' as const,

packages/backend/src/apps/tiles/actions/find-multiple-rows/index.ts

@@ -26,6 +26,10 @@ const action: IRawAction = {
       required: true,
       variables: false,
       showOptionValue: false,
+      clickableLink: {
+        label: 'View tile',
+        url: '/tiles/{value}',
+      },
       source: {
         type: 'query' as const,
         name: 'getDynamicData' as const,

packages/backend/src/apps/tiles/actions/find-single-row/index.ts

@@ -27,6 +27,10 @@ const action: IRawAction = {
       required: true,
       variables: false,
       showOptionValue: false,
+      clickableLink: {
+        label: 'View tile',
+        url: '/tiles/{value}',
+      },
       source: {
         type: 'query' as const,
         name: 'getDynamicData' as const,