chore: use safeParse to catch issues in dataOut

Author: kevinkim-ogp

packages/backend/src/apps/toolbox/__tests__/actions/for-each/get-data-out-metadata.test.ts

@@ -14,6 +14,7 @@ describe('getDataOutMetadata', () => {
     errorDetails: {},
     status: 'success' as const,
     appKey: 'toolbox',
+    key: 'forEach',
     createdAt: '2023-01-01T00:00:00Z',
     updatedAt: '2023-01-01T00:00:00Z',
     metadata: {},
@@ -561,7 +562,17 @@ describe('getDataOutMetadata', () => {
       }
       const executionStep = createMockExecutionStep(dataOut)
 
-      await expect(getDataOutMetadata(executionStep)).rejects.toThrow()
+      await expect(getDataOutMetadata(executionStep)).resolves.toBeNull()
+    })
+
+    it('should throw an error when inputSource is null', async () => {
+      const dataOut = {
+        iterations: 1,
+        inputSource: null as any,
+        items: ['some', 'data'],
+      }
+      const executionStep = createMockExecutionStep(dataOut)
+      await expect(getDataOutMetadata(executionStep)).resolves.toBeNull()
     })
   })
 
@@ -574,7 +585,7 @@ describe('getDataOutMetadata', () => {
       const executionStep = createMockExecutionStep(dataOut)
 
       // This should throw because dataOutSchema.parse will fail
-      await expect(getDataOutMetadata(executionStep)).rejects.toThrow()
+      await expect(getDataOutMetadata(executionStep)).resolves.toBeNull()
     })
 
     it('should handle dataOut with missing iterations field', async () => {
@@ -585,7 +596,7 @@ describe('getDataOutMetadata', () => {
       }
       const executionStep = createMockExecutionStep(dataOut)
 
-      await expect(getDataOutMetadata(executionStep)).rejects.toThrow()
+      await expect(getDataOutMetadata(executionStep)).resolves.toBeNull()
     })
 
     it('should handle dataOut with missing items field', async () => {
@@ -596,7 +607,7 @@ describe('getDataOutMetadata', () => {
       }
       const executionStep = createMockExecutionStep(dataOut)
 
-      await expect(getDataOutMetadata(executionStep)).rejects.toThrow()
+      await expect(getDataOutMetadata(executionStep)).resolves.toBeNull()
     })
   })
 

packages/backend/src/apps/toolbox/actions/for-each/get-data-out-metadata.ts

@@ -12,8 +12,12 @@ async function getDataOutMetadata(
     return null
   }
 
-  const dataOut = dataOutSchema.parse(rawDataOut)
-  const { inputSource, items } = dataOut
+  const dataOut = dataOutSchema.safeParse(rawDataOut)
+  if (dataOut.success === false) {
+    console.error(dataOut.error)
+    return null
+  }
+  const { inputSource, items } = dataOut.data
 
   const baseMetadata = {
     iterations: {
@@ -35,7 +39,7 @@ async function getDataOutMetadata(
       item: {
         label: 'Item',
         type: 'text',
-        displayedValue: dataOut.items[0] ?? '',
+        displayedValue: items[0] ?? '',
       },
     }
   }