Release v1.54.3 (#1258)

## Release v1.54.3
- Track launchdarkly flag evaluations
- Auto check formsg step
- Show link to executions page from editor / remove announcement modal
- Add a temporary catch for Telegram timeout error

Author: pregnantboy

package-lock.json

@@ -111,5 +111,5 @@
     "tsconfig-paths": "^4.2.0",
     "type-fest": "4.10.3"
   },
-  "version": "1.54.2"
+  "version": "1.54.3"
 }

packages/backend/package.json

@@ -11,7 +11,7 @@ import verifyCredentials from './verify-credentials'
 
 const auth: IUserAddedConnectionAuth = {
   connectionType: 'user-added' as const,
-
+  autoCheckStep: true,
   fields: [
     {
       key: 'formId',

packages/backend/src/apps/formsg/auth/index.ts

@@ -115,7 +115,7 @@ describe('send message', () => {
       mocks.httpPost.mockRejectedValueOnce(httpError)
       // throw partial step error message
       await expect(sendMessageAction.run($)).rejects.toThrowError(
-        'Connection issues',
+        RetriableError,
       )
     },
   )

packages/backend/src/apps/telegram-bot/__tests__/actions/send-message.test.ts

@@ -5,6 +5,7 @@ import get from 'lodash.get'
 import HttpError from '@/errors/http'
 import RetriableError from '@/errors/retriable-error'
 import StepError from '@/errors/step'
+import logger from '@/helpers/logger'
 import Step, { StepContext } from '@/models/step'
 
 export async function throwSendMessageError(
@@ -14,16 +15,34 @@ export async function throwSendMessageError(
   testRun: boolean,
 ): Promise<never> {
   const position = step.position
+  logger.error('Telegram bot error', {
+    error: err,
+  })
   // catch telegram errors with different error format for ETIMEDOUT and ECONNRESET: e.g. details: { error: 'connect ECONNREFUSED 127.0.0.1:3002' }
   const errorString = JSON.stringify(get(err, 'details.error', ''))
-  if (errorString.includes('ECONNRESET') || errorString.includes('ETIMEDOUT')) {
-    throw new StepError(
-      'Connection issues',
-      'Please retry in a few minutes because telegram is currently experiencing issues.',
-      position,
-      appName,
-      err,
-    )
+  if (
+    errorString.includes('ECONNRESET') ||
+    errorString.includes('ETIMEDOUT') ||
+    err.message.includes('ETIMEDOUT') ||
+    err.code === 'ETIMEDOUT'
+  ) {
+    throw new RetriableError({
+      error: 'Timeout error. Telegram may be experiencing issues.',
+      delayInMs: 'default',
+      delayType: 'step',
+    })
+  }
+
+  /**
+   * TODO: Temporary error handling since I cant find a way to catch the ETIMEDOUT error
+   */
+  const errorDetails = JSON.stringify(get(err, 'details', {}))
+  if (errorDetails === '{"error": "Error"}') {
+    throw new RetriableError({
+      error: 'Timeout error. Telegram may be experiencing issues.',
+      delayInMs: 'default',
+      delayType: 'step',
+    })
   }
 
   // catch telegram errors with proper http error format

packages/backend/src/apps/telegram-bot/common/throw-errors.ts

@@ -6,6 +6,7 @@ import BaseError from './base'
 
 export default class HttpError extends BaseError {
   response: AxiosResponse
+  code?: string
 
   constructor(error: AxiosError) {
     const computedError =
@@ -22,6 +23,9 @@ export default class HttpError extends BaseError {
       headers: {},
     }
 
+    // Pass code along
+    this.code = error.code
+
     //
     // Only preserve selected headers to avoid storing sensitive data.
     //

packages/backend/src/errors/http.ts

@@ -278,11 +278,11 @@ type ConnectionModalLabel {
 type AppAuth {
   connectionType: String!
   connectionRegistrationType: String
-
   fields: [Field] # Only for user-added connections
   authenticationSteps: [AuthenticationStep]
   reconnectionSteps: [ReconnectionStep]
   connectionModalLabel: ConnectionModalLabel
+  autoCheckStep: Boolean
 }
 
 enum ArgumentEnumType {

packages/backend/src/graphql/schema.graphql

@@ -1,6 +1,6 @@
 {
   "name": "frontend",
-  "version": "1.54.2",
+  "version": "1.54.3",
   "type": "module",
   "scripts": {
     "dev": "wait-on tcp:3000 && vite --host --force",

packages/frontend/package.json

@@ -1,6 +1,6 @@
 import { IFlow } from '@plumber/types'
 
-import { BiCog, BiInfoCircle } from 'react-icons/bi'
+import { BiCog, BiHistory, BiInfoCircle } from 'react-icons/bi'
 import { HiOutlineDotsVertical } from 'react-icons/hi'
 import { Link } from 'react-router-dom'
 import { Hide, HStack, MenuButton, MenuList, Show } from '@chakra-ui/react'
@@ -101,6 +101,45 @@ const SettingsItem = ({
   )
 }
 
+const ExecutionsItem = ({
+  flowId,
+  type,
+}: {
+  flowId: string
+  type: 'icon' | 'button'
+}) => {
+  if (type === 'button') {
+    return (
+      <Button
+        variant="clear"
+        aria-label="executions"
+        colorScheme="secondary"
+        as={Link}
+        to={URLS.EXECUTIONS_FOR_FLOW(flowId)}
+        w="100%"
+      >
+        Executions
+      </Button>
+    )
+  }
+  return (
+    <TouchableTooltip label="Executions" aria-label="executions-tooltip">
+      <IconButton
+        as={Link}
+        to={URLS.EXECUTIONS_FOR_FLOW(flowId)}
+        variant="clear"
+        aria-label="executions"
+        _hover={{
+          color: 'primary.500',
+          bg: 'interaction.muted.main.hover',
+        }}
+        icon={<BiHistory />}
+        colorScheme="secondary"
+      />
+    </TouchableTooltip>
+  )
+}
+
 interface EditorToolbarProps {
   flowId: string
   flow: IFlow
@@ -119,6 +158,7 @@ export default function EditorToolbar(props: EditorToolbarProps) {
     <>
       <Show above="md">
         <HStack>
+          <ExecutionsItem {...props} type="icon" />
           <GuideItem type="icon" />
           <SettingsItem {...props} type="icon" />
           <PublishButton {...props} />
@@ -140,6 +180,7 @@ export default function EditorToolbar(props: EditorToolbarProps) {
             gap={2}
             px={2}
           >
+            <ExecutionsItem {...props} type="button" />
             <GuideItem type="button" />
             <SettingsItem {...props} type="button" />
             <PublishButton {...props} />

packages/frontend/src/components/EditorLayout/EditorToolbar.tsx

@@ -279,7 +279,8 @@ export default function EditorLayout() {
         handleUnpublish={() => onFlowStatusUpdate(!flow.active)}
       />
 
-      {shouldOpenAnnouncementModal && (
+      {/* hardcoded to false to always hide announcement modal for now*/}
+      {shouldOpenAnnouncementModal && false && (
         <AnnouncementModal
           isOpen={shouldOpenAnnouncementModal}
           onClose={handleCloseAnnouncementModal}