Commit 9e13625
committed
PLU-488 [FIND-MULTIPLE-ROWS-5]: Get Excel column values dynamically (#1025)
## TL;DR
Refactored to dynamically obtain column values for the `getTableRows` action instead of storing them in the execution step’s `dataOut`, to avoid duplicate data — since the values are already stored in the row data.
**Note to reviewers**
The modal that displays the list of rows in table format will be updated in a subsequent PR. As of now, the test result can still be verified in the output after testing the step.
## What changed?
* Restructured output to align with Tiles multiple row output:
* `rows.rowData` to `data.rows` for better semantic clarity\
* Removed unnecessary consolidated column metadata as it is already available within the `data`
* Removed unnecessary `tableRowIndex` and `sheetRowNumber`
* Added explicit value paths (`data.rows.*.data.<hex-encoded-column-name>`) to column definitions for dynamic data access
* Changed the type in metadata from 'array' to 'multiple-row-object' to better represent the data structure
## How to test?
Set up the find table rows action and test the following:
- [ ] Number of rows returned is correct
- [ ] Test result shows the correct number of columns with:
- `id`: Tile column id (uuid)
- `name`: Tile column name
- `value`: step variable-like string in this format `data.rows.*.data.<hex-encoded-column-name>`
## Screenshots


1 parent 567ce00 commit 9e13625
File tree
6 files changed
+352
-276
lines changed- packages/backend/src/apps/m365-excel
- __tests__/actions
- actions/get-table-rows
- common/workbook-helpers/tables
6 files changed
+352
-276
lines changedLines changed: 62 additions & 85 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
7 | 41 | | |
8 | 42 | | |
9 | 43 | | |
| |||
15 | 49 | | |
16 | 50 | | |
17 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
18 | 62 | | |
19 | 63 | | |
20 | | - | |
21 | 64 | | |
22 | 65 | | |
23 | 66 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | 67 | | |
31 | 68 | | |
32 | 69 | | |
33 | 70 | | |
34 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
35 | 77 | | |
36 | 78 | | |
37 | 79 | | |
38 | 80 | | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
| 81 | + | |
77 | 82 | | |
78 | 83 | | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | 84 | | |
86 | 85 | | |
87 | 86 | | |
88 | 87 | | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
105 | 94 | | |
106 | 95 | | |
107 | 96 | | |
108 | 97 | | |
109 | 98 | | |
110 | 99 | | |
111 | 100 | | |
112 | | - | |
113 | | - | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
114 | 105 | | |
115 | 106 | | |
116 | 107 | | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
| 108 | + | |
132 | 109 | | |
133 | 110 | | |
134 | 111 | | |
| |||
0 commit comments