refactor: disable delete, skip query if no ids

Author: kevinkim-ogp

packages/backend/src/graphql/__tests__/queries/tiles/get-table-connections.itest.ts

@@ -1,8 +1,9 @@
 import crypto from 'crypto'
-import { beforeEach, describe, expect, it } from 'vitest'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 import getTableConnections from '@/graphql/queries/tiles/get-table-connections'
 import getTables from '@/graphql/queries/tiles/get-tables'
+import Flow from '@/models/flow'
 import Context from '@/types/express/context'
 
 import {
@@ -36,6 +37,8 @@ describe('get table connections query', () => {
       { tableIds: [] },
       context,
     )
+    const flowQuerySpy = vi.spyOn(Flow, 'query')
+    expect(flowQuerySpy).not.toHaveBeenCalled()
     expect(tableConnections).toEqual({})
     expect(Object.keys(tableConnections).length).toBe(0)
   })

packages/backend/src/graphql/queries/tiles/get-table-connections.ts

@@ -25,6 +25,9 @@ const getTableConnections: QueryResolvers['getTableConnections'] = async (
   if (!tableIds) {
     throw new Error('tableIds is required')
   }
+  if (tableIds.length === 0) {
+    return {}
+  }
 
   try {
     // get distinct rows of tables used in flows

packages/frontend/src/pages/Tiles/components/TileList.tsx

@@ -104,7 +104,7 @@ const TileListItem = ({
             <Text {...textStyles.lastOpened}>
               Last opened {toPrettyDateString(+table.lastAccessedAt)}
             </Text>
-            {table.role !== 'viewer' && numConnections > 0 && (
+            {numConnections > 0 && (
               <Skeleton isLoaded={!isConnectionsLoading}>
                 <Flex {...flexStyles.usedInPipes}>
                   <Icon
@@ -131,6 +131,7 @@ const TileListItem = ({
               variant="clear"
               aria-label="Remove"
               icon={<BiTrash />}
+              isDisabled={isConnectionsLoading}
               onClick={onDeleteButtonClick}
               visibility="hidden"
             />