refactor: send feedback via backend

Author: kevinkim-ogp

package-lock.json

@@ -19,9 +19,6 @@ const helmetOptions: HelmetOptions = {
         'https://rum-proxy.plumber.gov.sg',
         // For Lens Survey
         'https://lens.open.gov.sg',
-        // For Pair Rome and Istanbul
-        'https://istanbul.pair.gov.sg',
-        'https://rome.pair.gov.sg',
         // For S3 bucket
         'https://plumber-uat-attachment-bucket-private-0d9400e.s3.ap-southeast-1.amazonaws.com',
         'https://plumber-staging-attachment-bucket-private-ab28487.s3.ap-southeast-1.amazonaws.com',

packages/backend/src/helpers/csp.ts

@@ -0,0 +1,45 @@
+import type { Request, Response } from 'express'
+import { Router } from 'express'
+
+import { langfuseClient } from '@/helpers/langfuse'
+import logger from '@/helpers/logger'
+
+import { getAuthenticatedContext } from './middleware/authentication'
+
+interface ChatFeedbackRequest {
+  traceId: string
+  feedback: string
+}
+
+const handleChatFeedback = async (
+  req: Request,
+  res: Response,
+): Promise<void> => {
+  const context = getAuthenticatedContext(req)
+
+  try {
+    const { traceId, feedback } = req.body as ChatFeedbackRequest
+
+    if (!traceId || !feedback) {
+      res.status(400).json({ error: 'Trace ID and feedback are required' })
+    }
+
+    langfuseClient.score.create({
+      traceId,
+      id: `feedback-${traceId}-${context.currentUser.email}`,
+      name: 'user-feedback',
+      value: 0, // 1 for positive, 0 for negative
+      comment: feedback,
+    })
+    res.status(200).json({ success: true })
+  } catch (error) {
+    logger.error('Error submitting ai builder chat feedback:', error)
+    res.status(400).json({ error: 'Failed to submit feedback' })
+  }
+}
+
+const router = Router()
+
+router.post('/', handleChatFeedback)
+
+export default router

packages/backend/src/routes/api/chat-feedback.ts

@@ -5,6 +5,7 @@ import {
   setCurrentUserContext,
 } from './middleware/authentication'
 import chatRouter from './chat'
+import chatFeedbackRouter from './chat-feedback'
 
 const router = Router()
 
@@ -15,6 +16,7 @@ router.use(requireAuthentication)
 
 // Mount individual API routes
 router.use('/chat', chatRouter)
+router.use('/chat-feedback', chatFeedbackRouter)
 
 // Future routes can be added here:
 // router.use('/users', usersRouter)

packages/backend/src/routes/api/index.ts

@@ -41,7 +41,6 @@
     "dedent": "1.5.1",
     "escape-html": "1.0.3",
     "file-saver": "2.0.5",
-    "langfuse": "3.38.6",
     "lens-widget": "^1.37.0",
     "lodash": "^4.17.21",
     "lottie-web": "5.12.2",

packages/frontend/package.json

@@ -18,14 +18,6 @@ import {
   Textarea,
   useDisclosure,
 } from '@chakra-ui/react'
-import { LangfuseWeb } from 'langfuse'
-
-import appConfig from '@/config/app'
-
-const langfuse = new LangfuseWeb({
-  baseUrl: appConfig.pairRomeBaseUrl,
-  publicKey: appConfig.pairRomePublicKey,
-})
 
 interface ChatMessageToolbarProps {
   traceId: string
@@ -38,22 +30,23 @@ export default function ChatMessageToolbar({
   const firstFieldRef = React.useRef(null)
   const [comment, setComment] = useState('')
 
-  const handleSubmitFeedback = (comment: string) => {
+  const handleSubmitFeedback = async (comment: string) => {
     try {
       if (!traceId) {
         return
       }
 
-      // Send feedback to Rome / Istanbul
-      langfuse.score({
-        traceId,
-        id: `user-feedback-${traceId}`,
-        name: 'user-feedback',
-        value: 0, // 1 for positive, 0 for negative
-        comment,
+      // NOTE: we send feedback to the backend instead of using Langfuse directly
+      // as there are additional headers required to call Rome/Istanbul endpoints
+      // that should not be exposed to the frontend
+      await fetch('/api/chat-feedback', {
+        method: 'POST',
+        headers: { 'Content-Type': 'application/json' },
+        body: JSON.stringify({ traceId, feedback: comment }),
       })
-    } catch (error) {
-      console.error('Error submitting feedback:', error)
+    } catch {
+      // don't throw error if feedback submission fails
+      // as it is not critical to the user experience
     } finally {
       onClose()
       setComment('')

packages/frontend/src/components/AiBuilder/components/ChatInterface/ChatMessageToolbar.tsx

@@ -7,8 +7,6 @@ interface AppConfig {
   lensSurveyClientKey: string
   ssoClientId: string
   ssoHostname: string
-  pairRomeBaseUrl: string
-  pairRomePublicKey: string
 }
 
 function getAppConfig(): AppConfig {
@@ -30,8 +28,6 @@ function getAppConfig(): AppConfig {
         lensSurveyClientKey: 'cm85ca2f300053ooz4vydrmyw',
         ssoClientId: 'plumber-prod',
         ssoHostname: 'https://sso.open.gov.sg',
-        pairRomeBaseUrl: 'https://rome.pair.gov.sg',
-        pairRomePublicKey: '', // TODO: add public key
         ...commonEnv,
       }
     // UAT and staging differ for the lens survey client key only
@@ -43,8 +39,6 @@ function getAppConfig(): AppConfig {
         lensSurveyClientKey: 'cm8fp8i030008zm2tbuc07xe5',
         ssoClientId: 'plumber-uat',
         ssoHostname: 'https://sso.open.gov.sg',
-        pairRomeBaseUrl: 'https://rome.pair.gov.sg',
-        pairRomePublicKey: '', // TODO: add public key
         ...commonEnv,
       }
     case 'staging':
@@ -55,9 +49,6 @@ function getAppConfig(): AppConfig {
         lensSurveyClientKey: 'cm86psst900052orfqetz3gz5',
         ssoClientId: 'plumber-staging',
         ssoHostname: 'https://sso.open.gov.sg',
-        // TODO: update to use Rome when ready
-        pairRomeBaseUrl: 'https://istanbul.pair.gov.sg',
-        pairRomePublicKey: 'pk-lf-1f6acb1e-85c0-4af7-bea7-6f465f7c0141',
         ...commonEnv,
       }
     default:
@@ -68,9 +59,6 @@ function getAppConfig(): AppConfig {
         lensSurveyClientKey: 'cm8fpeah2000gzm2t572lhfti',
         ssoClientId: 'plumber-local',
         ssoHostname: 'http://localhost:5354',
-        // TODO: update to use Rome when ready
-        pairRomeBaseUrl: 'https://istanbul.pair.gov.sg',
-        pairRomePublicKey: 'pk-lf-1f6acb1e-85c0-4af7-bea7-6f465f7c0141',
         ...commonEnv,
       }
   }