Release v1.42.0 (#1008)

## Changes
1. Use RDS Proxy
2. Read postman queue rate limit from env var
3. Hide empty row ID tooltip in update row action

## To check
Env vars are set:
- [x] plumber-prod-rds-proxy-host
- [x] plumber-prod-postman-rate-limit

Author: pregnantboy

ecs/env.json

@@ -43,10 +43,6 @@
     {
       "name": "ENABLE_BULLMQ_DASHBOARD",
       "value": "true"
-    },
-    {
-      "name": "POSTMAN_SMS_QPS_LIMIT_PER_CAMPAIGN",
-      "value": "5"
     }
   ],
   "secrets": [
@@ -217,6 +213,14 @@
     {
       "name": "ONBOARDING_EMAIL_WEBHOOK_URL",
       "valueFrom": "plumber-onboarding-email-webhook-url"
+    },
+    {
+      "name": "POSTMAN_SMS_QPS_LIMIT_PER_CAMPAIGN",
+      "valueFrom": "plumber-<ENVIRONMENT>-postman-sms-qps"
+    },
+    {
+      "name": "RDS_PROXY_HOST",
+      "valueFrom": "plumber-<ENVIRONMENT>-rds-proxy-host"
     }
   ]
 }

package-lock.json

@@ -106,5 +106,5 @@
     "tsconfig-paths": "^4.2.0",
     "type-fest": "4.10.3"
   },
-  "version": "1.41.0"
+  "version": "1.42.0"
 }

packages/backend/package.json

@@ -6,7 +6,6 @@ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 import HttpError from '@/errors/http'
 import PartialStepError from '@/errors/partial-error'
 import RetriableError from '@/errors/retriable-error'
-import StepError from '@/errors/step'
 
 import sendTransactionalEmail from '../../actions/send-transactional-email'
 
@@ -140,15 +139,6 @@ describe('send transactional email', () => {
       errorStatusText: 'Bad Request',
       stepErrorName: 'Unsupported attachment file type',
     },
-    {
-      postmanResponseData: {
-        code: 'rate_limit',
-        message: 'Too many requests. Please try again later.',
-      },
-      errorStatusCode: 429,
-      errorStatusText: 'Bad Request',
-      stepErrorName: 'Too many requests',
-    },
   ])(
     'should throw step error for different postman errors',
     async ({
@@ -337,7 +327,9 @@ describe('send transactional email', () => {
         } as AxiosError),
       )
 
-    await expect(sendTransactionalEmail.run($)).rejects.toThrowError(StepError)
+    await expect(sendTransactionalEmail.run($)).rejects.toThrowError(
+      RetriableError,
+    )
     expect($.setActionItem).toHaveBeenCalledWith({
       raw: {
         status: ['ACCEPTED', 'BLACKLISTED', 'RATE-LIMITED'],

packages/backend/src/apps/postman/__tests__/actions/send-transactional-email.test.ts

@@ -92,13 +92,11 @@ export function throwPostmanStepError({
     }
     case 'RATE-LIMITED':
       // this will be auto-retried later on
-      throw new StepError(
-        'Rate limit exceeded',
-        'Too many emails are being sent. Please wait for a while before retrying.',
-        position,
-        appName,
-        error,
-      )
+      throw new RetriableError({
+        error: error.details,
+        delayInMs: 'default',
+        delayType: 'queue',
+      })
     case 'INVALID-ATTACHMENT':
       throw new StepError(
         'Unsupported attachment file type',

packages/backend/src/apps/postman/common/throw-errors.ts

@@ -1,8 +1,7 @@
 import { IApp } from '@plumber/types'
 
-import { getGenericAppQueue } from '@/queues/helpers/get-generic-app-queue'
-
 import actions from './actions'
+import queue from './queue'
 
 const app: IApp = {
   name: 'Email by Postman',
@@ -21,7 +20,7 @@ const app: IApp = {
     url: 'https://demo.arcade.software/VppMAbGKfFXFEsKxnKiw?embed&show_copy_link=true',
     title: 'Setting up Email by Postman',
   },
-  queue: getGenericAppQueue('POSTMAN_EMAIL'),
+  queue,
   category: 'communication',
 }
 

packages/backend/src/apps/postman/index.ts

@@ -0,0 +1,13 @@
+import type { IAppQueue } from '@plumber/types'
+
+import appConfig from '@/config/app'
+
+const queueSettings = {
+  queueRateLimit: {
+    duration: 1000,
+    max: appConfig.postman.rateLimit,
+  },
+  isQueueDelayable: true,
+} satisfies IAppQueue
+
+export default queueSettings

packages/backend/src/apps/postman/queue/index.ts

@@ -171,7 +171,7 @@ describe('tiles create row action', () => {
     expect($.setActionItem).toBeCalledWith({
       raw: {
         rowsFound: 0,
-        rowId: '',
+        rowId: ' ',
         row: emptyRow,
       },
     })

packages/backend/src/apps/tiles/__tests__/actions/find-single-row.itest.ts

@@ -198,7 +198,8 @@ const action: IRawAction = {
       $.setActionItem({
         raw: {
           rowsFound: 0,
-          rowId: '',
+          // NOTE: intentionally return whitespace so that a solid pill is shown
+          rowId: ' ',
           row: emptyRow,
         } satisfies FindSingleRowOutput,
       })

packages/backend/src/apps/tiles/actions/find-single-row/index.ts

@@ -69,7 +69,8 @@ const appConfig: AppConfig = {
   version: process.env.npm_package_version,
   postgresDatabase: process.env.POSTGRES_DATABASE || 'plumber_dev',
   postgresPort: parseInt(process.env.POSTGRES_PORT || '5432'),
-  postgresHost: process.env.POSTGRES_HOST || 'localhost',
+  postgresHost:
+    process.env.RDS_PROXY_HOST || process.env.POSTGRES_HOST || 'localhost',
   postgresUsername: process.env.POSTGRES_USERNAME,
   postgresPassword: process.env.POSTGRES_PASSWORD,
   postgresEnableSsl: process.env.POSTGRES_ENABLE_SSL === 'true',