remove hideBlankRow param, depend on required field to show blank row

Author: kevinkim-ogp

packages/backend/src/apps/custom-api/actions/http-request/index.ts

@@ -54,7 +54,6 @@ const action: IRawAction = {
       description: 'Add custom headers here.',
       variables: true,
       addRowButtonText: 'Add',
-      hideBlankRow: true,
       subFields: [
         {
           placeholder: 'Key',

packages/backend/src/apps/lettersg/actions/create-letter/index.ts

@@ -69,7 +69,7 @@ const action: IRawAction = {
       label: 'Personalised fields',
       key: 'letterParams',
       type: 'multirow' as const,
-      required: false,
+      required: true,
       description:
         'Specify values for each personalised field in your template.',
 

packages/backend/src/graphql/schema.graphql

@@ -189,7 +189,6 @@ type ActionSubstepArgument {
   source: ActionSubstepArgumentSource
   hiddenIf: FieldVisibilityCondition
   addRowButtonText: String
-  hideBlankRow: Boolean
 
   # Only for dropdown
   addNewOption: DropdownAddNewOption

packages/frontend/src/components/InputCreator/index.tsx

@@ -164,7 +164,6 @@ export default function InputCreator(props: InputCreatorProps): JSX.Element {
         subFields={schema.subFields}
         required={required}
         addRowButtonText={schema.addRowButtonText}
-        hideBlankRow={schema.hideBlankRow}
         showDivider={type !== 'multirow-multicol'}
         type={type}
         // These are InputCreatorProps which MultiRow will forward.

packages/frontend/src/components/MultiRow/index.tsx

@@ -21,7 +21,6 @@ export type MultiRowProps = {
   label?: string
   description?: string
   flexDir?: string
-  hideBlankRow?: boolean
   showDivider?: boolean
   addRowButtonText?: string
   type?: string
@@ -35,7 +34,6 @@ function MultiRow(props: MultiRowProps): JSX.Element {
     required,
     description,
     addRowButtonText,
-    hideBlankRow,
     showDivider,
     type,
     ...forwardedInputCreatorProps
@@ -74,7 +72,7 @@ function MultiRow(props: MultiRowProps): JSX.Element {
     <Controller
       name={name}
       control={control}
-      defaultValue={hideBlankRow ? [] : [{ ...newRowDefaultValue }]}
+      defaultValue={!required ? [] : [{ ...newRowDefaultValue }]}
       render={({ field: { value: fallbackRows } }): JSX.Element => {
         // HACKFIX (ogp-weeloong): I don't know why `rows` lags behind
         // `fallbackRows` on the 1st render.

packages/frontend/src/graphql/queries/get-apps.ts

@@ -189,7 +189,6 @@ export const GET_APPS = gql`
             variableTypes
             allowArbitrary
             addRowButtonText
-            hideBlankRow
             showOptionValue
             value
             options {

packages/types/index.d.ts

@@ -354,7 +354,6 @@ export interface IFieldMultiRowMultiCol extends IBaseField {
   type: 'multirow-multicol'
   value?: string
   addRowButtonText?: string
-  hideBlankRow?: boolean
 
   subFields: IField[]
 }
@@ -363,7 +362,6 @@ export interface IFieldMultiRow extends IBaseField {
   type: 'multirow'
   value?: string
   addRowButtonText?: string
-  hideBlankRow?: boolean
 
   subFields: IField[]
 }