Skip to content

Commit c8cd8fe

Browse files
committed
add changes based on code review
1 parent 5ebc1bf commit c8cd8fe

File tree

6 files changed

+44
-29
lines changed

6 files changed

+44
-29
lines changed

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/frontend/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"lens-widget": "^1.37.0",
4343
"lodash": "^4.17.21",
4444
"lodash.get": "4.4.2",
45-
"lottie-react": "^2.4.1",
45+
"lottie-react": "2.4.1",
4646
"lottie-web": "5.12.2",
4747
"luxon": "^2.3.1",
4848
"node-html-parser": "6.1.13",

packages/frontend/src/pages/Landing/FaqSection.tsx

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ import {
1010
Text,
1111
} from '@chakra-ui/react'
1212

13+
import MarkdownRenderer from '@/components/MarkdownRenderer'
14+
import * as URLS from '@/config/urls'
15+
1316
const faqs = [
1417
{
1518
question: 'Is Plumber free?',
@@ -22,8 +25,7 @@ const faqs = [
2225
},
2326
{
2427
question: 'Do you offer technical support?',
25-
answer:
26-
'If you run into any difficulties setting up your workflows, you can reach out to us at https://go.gov.sg/plumber-support.',
28+
answer: `If you run into any difficulties setting up your workflows, you can reach out to us [here](${URLS.SUPPORT_FORM_LINK}).`,
2729
},
2830
{
2931
question: 'Which agencies are using Plumber?',
@@ -76,9 +78,16 @@ export default function FaqSection() {
7678
</AccordionButton>
7779

7880
<AccordionPanel mt={2} pr={12} px={0}>
79-
<Text fontSize="base" color="gray.600">
80-
{faq.answer}
81-
</Text>
81+
<MarkdownRenderer
82+
source={faq.answer}
83+
components={{
84+
p: ({ children }) => (
85+
<Text fontSize="base" color="gray.600">
86+
{children}
87+
</Text>
88+
),
89+
}}
90+
/>
8291
</AccordionPanel>
8392
</AccordionItem>
8493
))}

packages/frontend/src/pages/Landing/HeaderBar.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,12 @@ export default function HeaderBar() {
117117
</Popover> */}
118118

119119
{/* TODO: check if this link needs to be changed */}
120-
<Button as="a" href={URLS.GUIDE_LINK} variant="clear">
120+
<Button
121+
as="a"
122+
href={URLS.GUIDE_LINK}
123+
target="_blank"
124+
variant="clear"
125+
>
121126
Releases
122127
</Button>
123128

packages/frontend/src/pages/Landing/UseCases.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ import * as URLS from '@/config/urls'
1616
const posts = [
1717
{
1818
title:
19-
"How Attorney General's Chamber reduced 50% of time spent on administrative onboarding processes",
19+
"How Attorney-General's Chambers reduced 50% of time spent on administrative onboarding processes",
2020
href: URLS.HUMAN_RESOURCE,
2121
description: ' ',
2222
imageUrl: AgcLogo,
23-
agency: "Attorney General's Chamber",
23+
agency: "Attorney-General's Chambers",
2424
},
2525
]
2626

packages/frontend/src/pages/Landing/UseCasesPages/HumanResource.tsx

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ function FirstContentBox() {
1212
<ContentBox headerText="Life before Plumber">
1313
<Text>
1414
Prior to automating this process, onboarding was managed manually. This
15-
included information seeking and declaration through emails. Upon
16-
receipt of information, HR staff will forward it to relevant
17-
stakeholders to process onboarding items, such as staff passes.
15+
included information gathering and declarations via email. Upon receipt
16+
of information, HR staff will forward it to relevant stakeholders to
17+
process onboarding items, such as staff passes.
1818
</Text>
1919

2020
<Text>
2121
This process was prone to human error. For instance, a missed or delayed
22-
referral by HR will affect an employees’ onboarding experience.
22+
referral by HR will affect an employee’s onboarding experience.
2323
</Text>
2424
</ContentBox>
2525
)
@@ -29,15 +29,16 @@ function SecondContentBox() {
2929
return (
3030
<ContentBox headerText="Paving the way for transformation">
3131
<Text>
32-
Zhi Hao, a HR Business Partner in AGC, reviewed the existing operational
33-
process and identified some process steps for potential automation. The
34-
scope of change started small but he gradually expanded automating more
35-
parts of the workflow.
32+
Zhi Hao, an HR Business Partner at AGC, reviewed the existing
33+
operational process and identified some steps for potential automation.
34+
The scope of change started small, but he gradually expanded automation
35+
to more parts of the workflow.
3636
</Text>
3737

3838
<Text>
39-
With Plumber, the information is now directly available to stakeholders
40-
after the employees’ input without the need for manual referral.
39+
With Plumber, the information is now made directly available to
40+
stakeholders after employees’ input, without the need for manual
41+
referral.
4142
</Text>
4243
</ContentBox>
4344
)
@@ -47,14 +48,14 @@ function ThirdContentBox() {
4748
return (
4849
<ContentBox headerText="A better HR experience for all">
4950
<Text>
50-
50 employees have been onboard over the past 6 months since this process
51-
was automated. This amounts to 50 hours of administrative time saved,
52-
which has gone into other HR strategic objectives.
51+
50 employees have been onboarded over the past 6 months since this
52+
process was automated. This amounts to 50 hours of administrative time
53+
saved, which has been redirected towards other HR strategic objectives.
5354
</Text>
5455

5556
<Text>
56-
The team transitioned into the automated work process late last year and
57-
is periodically reviewing it for improvement.
57+
The team transitioned to the automated work process late last year and
58+
is periodically reviewing it for improvements.
5859
</Text>
5960
</ContentBox>
6061
)
@@ -67,12 +68,12 @@ export default function HumanResource() {
6768

6869
<SummarySection
6970
category="Human Resource"
70-
title="How Attorney General's Chamber reduced 50% of time spent on administrative onboarding processes"
71+
title="How Attorney-General's Chambers reduced 50% of time spent on administrative onboarding processes"
7172
description="Administrative work to onboard a new joiner on their first day of work typically took around 2 hours cumulatively, and was prone to human error"
7273
benefits={[
73-
'50% time saved to onboard new employee',
74-
'95% reduction in errors by automating',
75-
'Able to focus on more important work like strategy after automating process',
74+
'50% reduction in time taken to onboard a new employee',
75+
'95% reduction in errors through automation',
76+
'Able to focus on more important work, such as strategy, after automating the process',
7677
]}
7778
/>
7879

0 commit comments

Comments
 (0)