chore: update test name, refactor column processing

Author: kevinkim-ogp

packages/backend/src/apps/toolbox/__tests__/actions/for-each/get-data-out-metadata.test.ts

@@ -554,7 +554,7 @@ describe('getDataOutMetadata', () => {
   })
 
   describe('when inputSource is unrecognized', () => {
-    it('should throw an error for unknown input source', async () => {
+    it('should return null for unknown input source', async () => {
       const dataOut = {
         iterations: 1,
         inputSource: 'unknown-source',
@@ -565,7 +565,7 @@ describe('getDataOutMetadata', () => {
       await expect(getDataOutMetadata(executionStep)).resolves.toBeNull()
     })
 
-    it('should throw an error when inputSource is null', async () => {
+    it('should return null when inputSource is null', async () => {
       const dataOut = {
         iterations: 1,
         inputSource: null as any,
@@ -577,7 +577,7 @@ describe('getDataOutMetadata', () => {
   })
 
   describe('schema validation edge cases', () => {
-    it('should handle dataOut that fails schema validation', async () => {
+    it('should return null when dataOut fails schema validation', async () => {
       const dataOut = {
         // missing required fields
         invalidField: 'invalid',

packages/backend/src/apps/toolbox/common/get-for-each-variables.ts

@@ -38,24 +38,27 @@ function processColumns(data: MultipleRowObject): {
   inputSource: InputSource
   processedColumns: ProcessedColumn[]
 } {
-  const processedColumns: ProcessedColumn[] = []
-  let inputSource = null
-
-  data.columns.forEach((column: any) => {
-    // NOTE: we can tell if its a tile column by its column id
-    // tiles will either have uuid or ulid as column id
-    if (ULID_REGEX.test(column.id) || UUID_REGEX.test(column.id)) {
-      inputSource = FOR_EACH_INPUT_SOURCE.TILES
-    } else {
-      inputSource = FOR_EACH_INPUT_SOURCE.M365_EXCEL
+  if (data.columns.length === 0) {
+    return {
+      inputSource: null,
+      processedColumns: [],
     }
+  }
 
-    processedColumns.push({
-      id: column.id,
-      name: column.name,
-      value: `items.rows.${FOR_EACH_ITERATION_KEY}.data.${column.id}`,
-    })
-  })
+  // NOTE: we can tell if its a tile column by its column id
+  // tiles will either have uuid or ulid as column id
+  const hasTileColumn = data.columns.every(
+    (column: any) => ULID_REGEX.test(column.id) || UUID_REGEX.test(column.id),
+  )
+  const inputSource = hasTileColumn
+    ? FOR_EACH_INPUT_SOURCE.TILES
+    : FOR_EACH_INPUT_SOURCE.M365_EXCEL
+
+  const processedColumns = data.columns.map((column: any) => ({
+    id: column.id,
+    name: column.name,
+    value: `items.rows.${FOR_EACH_ITERATION_KEY}.data.${column.id}`,
+  }))
 
   // NOTE: only tiles will have rowId
   if (inputSource === FOR_EACH_INPUT_SOURCE.TILES) {