chore: show correct err msg for deleted tileh

Author: kevinkim-ogp

packages/backend/src/apps/tiles/__tests__/actions/create-row.itest.ts

@@ -83,4 +83,14 @@ describe('tiles create row action', () => {
     $.user = viewer
     await expect(createRowAction.run($)).rejects.toThrow(StepError)
   })
+
+  it('should throw correct error if Tile deleted', async () => {
+    $.user = editor
+    await TableMetadata.query()
+      .patch({
+        deletedAt: new Date().toISOString(),
+      })
+      .where({ id: $.step.parameters.tableId })
+    await expect(createRowAction.run($)).rejects.toThrow(StepError)
+  })
 })

packages/backend/src/apps/tiles/actions/create-row/index.ts

@@ -97,6 +97,14 @@ const action: IRawAction = {
     await TableCollaborator.hasAccess($.user?.id, tableId, 'editor', $)
 
     const table = await TableMetadata.query().findById(tableId)
+    if (!table) {
+      throw new StepError(
+        'Tile not found',
+        'Tile may have been deleted. Please check your tile.',
+        $.step.position,
+        'tiles',
+      )
+    }
 
     /**
      * convert array to object

packages/backend/src/apps/tiles/dynamic-data/list-columns.ts

@@ -26,7 +26,9 @@ const dynamicData: IDynamicData = {
         .$relatedQuery('tables')
         .findById($.step.parameters.tableId as string)
         .whereIn('role', ['owner', 'editor'])
-        .throwIfNotFound()
+        .throwIfNotFound({
+          message: 'Tile may have been deleted. Please check your tile.',
+        })
       const columns = await tile
         .$relatedQuery('columns')
         .orderBy('position', 'asc')
@@ -38,14 +40,17 @@ const dynamicData: IDynamicData = {
           name: name,
         })),
       }
-    } catch (e) {
-      logger.error('Tiles dynamic data: list columns error', {
-        userId: $.user?.id,
-        tableId: $.step.parameters.tableId,
-        flowId: $.flow?.id,
-        stepId: $.step?.id,
-      })
-      throw new Error('Unable to fetch columns')
+    } catch (err) {
+      logger.error(
+        err.data.message ?? 'Tiles dynamic data: list columns error',
+        {
+          userId: $.user?.id,
+          tableId: $.step.parameters.tableId,
+          flowId: $.flow?.id,
+          stepId: $.step?.id,
+        },
+      )
+      throw new Error(err.data.message ?? 'Unable to fetch columns')
     }
   },
 }

packages/backend/src/graphql/__tests__/mutations/tiles/delete-table.itest.ts

@@ -3,6 +3,7 @@ import { beforeEach, describe, expect, it } from 'vitest'
 
 import { ForbiddenError } from '@/errors/graphql-errors'
 import deleteTable from '@/graphql/mutations/tiles/delete-table'
+import TableCollaborator from '@/models/table-collaborators'
 import TableMetadata from '@/models/table-metadata'
 import User from '@/models/user'
 import Context from '@/types/express/context'
@@ -35,7 +36,7 @@ describe('delete table mutation', () => {
     })
   })
 
-  it('should delete table and columns', async () => {
+  it('should delete table, columns and collaborators', async () => {
     const success = await deleteTable(
       null,
       { input: { id: dummyTable.id } },
@@ -46,9 +47,13 @@ describe('delete table mutation', () => {
       .resultSize()
 
     const deletedTable = await TableMetadata.query().findById(dummyTable.id)
+    const tableCollaborators = await TableCollaborator.query().where({
+      table_id: dummyTable.id,
+    })
     expect(success).toBe(true)
     expect(deletedTable).toBeUndefined()
     expect(tableColumnCount).toBe(0)
+    expect(tableCollaborators.length).toBe(0)
   })
 
   it('should throw an error if table is not found', async () => {

packages/backend/src/graphql/mutations/tiles/delete-table.ts

@@ -20,6 +20,9 @@ const deleteTable: MutationResolvers['deleteTable'] = async (
       .throwIfNotFound()
 
     await table.$relatedQuery('columns', trx).delete()
+    await TableCollaborator.query().where({ table_id: params.input.id }).patch({
+      deletedAt: new Date().toISOString(),
+    })
     await table.$query(trx).delete()
   })