chore: add comments

Author: pregnantboy

packages/backend/src/graphql/admin/mutations/add-gsi.ts

@@ -1,4 +1,5 @@
-import { flattenJsonb } from '@/helpers/knex-jsonb-flatten'
+import { DataPropertyNames } from 'objection'
+
 import { GSIS } from '@/models/dynamodb/table-row'
 import TableColumnMetadata from '@/models/table-column-metadata'
 
@@ -37,17 +38,14 @@ const createTable: AdminMutationResolvers['addGsi'] = async (
   }
 
   await TableColumnMetadata.query()
-    .patch(
-      flattenJsonb({
-        config: {
-          gsi: {
-            indexName: correspondingGsi.gsi,
-            type: correspondingGsi.type,
-            status: 'pending',
-          },
-        },
-      }),
-    )
+    .patch({
+      ['config:gsi' as DataPropertyNames<TableColumnMetadata>]: {
+        indexName: correspondingGsi.gsi,
+        type: correspondingGsi.type,
+        status: 'pending',
+        patchFrom: new Date().toISOString(),
+      },
+    })
     .where({ id: columnId })
 
   return true

packages/backend/src/graphql/mutation-resolvers.ts

@@ -1,4 +1,7 @@
-import type { MutationResolvers } from './__generated__/types.generated'
+import type {
+  AdminMutation,
+  MutationResolvers,
+} from './__generated__/types.generated'
 import bulkRetryExecutions from './mutations/bulk-retry-executions'
 import createConnection from './mutations/create-connection'
 import createFlow from './mutations/create-flow'
@@ -86,5 +89,5 @@ export default {
   // This is a special stub that enables us to group all our admin-related
   // mutations into a special AdminMutation object; each "mutations" is handled by field
   // resolvers defined in @/graphql/admin/mutations.
-  admin: () => ({}),
+  admin: () => ({} as AdminMutation),
 } satisfies MutationResolvers

packages/backend/src/helpers/authentication.ts

@@ -103,8 +103,11 @@ const authentication = shield(
       // Not OTP, but no real reason to be looser than OTP.
       loginWithSgid: rateLimitRule({ window: '1s', max: 5 }),
       loginWithSelectedSgid: rateLimitRule({ window: '1s', max: 5 }),
+      // Only admins can access admin mutations, we dont want to default it in '*'
       admin: isAdminOperation,
     },
+    // This is not needed since it's already added above
+    // but adding it here in case we want to make more granular in the future
     AdminMutation: isAdminOperation,
   },
   {