fix: check table exists before access

kevinkim-ogp · kevinkim-ogp · commit e16f96c6d012 · 2024-11-27T14:04:49.000+08:00
diff --git a/packages/backend/src/apps/tiles/actions/create-row/index.ts b/packages/backend/src/apps/tiles/actions/create-row/index.ts
@@ -94,8 +94,6 @@ const action: IRawAction = {
       rowData: { columnId: string; cellValue: string }[]
     }
 
-    await TableCollaborator.hasAccess($.user?.id, tableId, 'editor', $)
-
     const table = await TableMetadata.query().findById(tableId)
     if (!table) {
       throw new StepError(
@@ -106,6 +104,8 @@ const action: IRawAction = {
       )
     }
 
+    await TableCollaborator.hasAccess($.user?.id, tableId, 'editor', $)
+
     /**
      * convert array to object
      * [{columnId: 'abc', cellValue: 'test'}] => {abc: 'test'}

Original file line number	Diff line number	Diff line change
`@@ -94,8 +94,6 @@ const action: IRawAction = {`
`94`	`94`	`rowData: { columnId: string; cellValue: string }[]`
`95`	`95`	`}`
`96`	`96`
`97`		`- await TableCollaborator.hasAccess($.user?.id, tableId, 'editor', $)`
`98`		`-`
`99`	`97`	`const table = await TableMetadata.query().findById(tableId)`
`100`	`98`	`if (!table) {`
`101`	`99`	`throw new StepError(`
`@@ -106,6 +104,8 @@ const action: IRawAction = {`
`106`	`104`	`)`
`107`	`105`	`}`
`108`	`106`
	`107`	`+ await TableCollaborator.hasAccess($.user?.id, tableId, 'editor', $)`
	`108`	`+`
`109`	`109`	`/**`
`110`	`110`	`* convert array to object`
`111`	`111`	`* [{columnId: 'abc', cellValue: 'test'}] => {abc: 'test'}`