Revert "fix: stop deleting execution steps on step delete"

This reverts commit 8e81bf2.

Author: kevinkim-ogp

packages/backend/src/graphql/mutations/delete-step.ts

@@ -40,12 +40,7 @@ const deleteStep: MutationResolvers['deleteStep'] = async (
     }
 
     const stepIds = steps.map((step) => step.id)
-
-    /**
-     * NOTE: do not delete execution steps
-     * The deletion causes RDS CPU Utilisation to spike
-     */
-    // await Step.relatedQuery('executionSteps', trx).for(stepIds).delete()
+    await Step.relatedQuery('executionSteps', trx).for(stepIds).delete()
     await Step.query(trx).findByIds(stepIds).delete()
 
     await steps[0].flow

packages/backend/src/helpers/get-test-execution-steps.ts

@@ -25,13 +25,7 @@ export async function getTestExecutionSteps(
 
   if (flow.testExecution && !ignoreTestExecutionId) {
     const testExecutionSteps = flow.testExecution.executionSteps
-
-    /**
-     * NOTE: filters out test execution steps for steps that have been deleted
-     */
-    testExecutionSteps
-      .filter((e) => e.step)
-      .sort((a, b) => a.step.position - b.step.position)
+    testExecutionSteps.sort((a, b) => a.step.position - b.step.position)
 
     /**
      * Sanity check to ensure not more than 1 execution step per step is returned

packages/backend/src/services/test-step.ts

@@ -38,7 +38,7 @@ const testStep = async (options: TestStepOptions): Promise<TestStepResult> => {
 
   const testExecutionSteps = await getTestExecutionSteps(flow.id)
   const testActionExecutionSteps = testExecutionSteps.filter(
-    (executionStep) => executionStep.step && executionStep.step.isAction,
+    (executionStep) => executionStep.step.isAction,
   )
 
   /**