fix: dynamic data and default field type

Author: pregnantboy

packages/backend/src/apps/gathersg/actions/update-case/index.ts

@@ -24,7 +24,6 @@ const action: IRawAction = {
         'You can only select a step variable here to make reference to.',
       required: true,
       variables: true,
-      singleVariableSelection: true,
     },
     // TODO: see if it is possible to get all possible statuses from the API
     {
@@ -34,16 +33,12 @@ const action: IRawAction = {
       description: 'Enter the status you want to update the case to.',
       required: false,
       variables: true,
-      hiddenIf: {
-        fieldKey: 'caseUuid',
-        op: 'is_empty',
-      },
     },
     {
       label: 'Case fields',
       key: 'caseFields',
       type: 'multirow-multicol' as const,
-      required: true,
+      required: false,
       description:
         'Specify values for each field you want to update in your case. Note that fields that require an array of objects as a value are not supported yet.',
 
@@ -64,10 +59,6 @@ const action: IRawAction = {
                 name: 'key',
                 value: 'getCaseFields',
               },
-              {
-                name: 'parameters.caseUuid',
-                value: '{parameters.caseUuid}',
-              },
             ],
           },
           customStyle: { flex: 2 },
@@ -78,6 +69,8 @@ const action: IRawAction = {
           type: 'dropdown' as const,
           showOptionValue: false,
           required: true,
+          value: 'string',
+          variables: false,
           options: [
             {
               label: 'String',
@@ -108,10 +101,6 @@ const action: IRawAction = {
           customStyle: { flex: 3, minWidth: 0, maxWidth: '60%' },
         },
       ],
-      hiddenIf: {
-        fieldKey: 'caseUuid',
-        op: 'is_empty',
-      },
     },
   ],
 

packages/backend/src/apps/gathersg/actions/update-case/schema.ts

@@ -20,7 +20,8 @@ export const requestSchema = z
       .array(
         z.object({
           field: z.string().trim().min(1, 'Field empty'),
-          fieldType: fieldTypeEnum,
+          // we add nullish here because defaultValue or value doesnt work properly in dropdown
+          fieldType: fieldTypeEnum.nullish(),
           value: z.string().trim().nullish(),
         }),
       )

packages/backend/src/apps/gathersg/dynamic-data/get-case-fields.ts

@@ -5,49 +5,53 @@ import {
 } from '@plumber/types'
 
 import HttpError from '@/errors/http'
-import computeParameters from '@/helpers/compute-parameters'
-import ExecutionStep from '@/models/execution-step'
 
 import { GatherSGError } from '../common/types'
 
+/**
+ * Subset of result
+ */
+interface GatherSGCase {
+  uuid: string
+  createdAt: string
+  updatedAt: string
+  status: {
+    uuid: string
+    name: string
+    color: string
+    isFinal: boolean
+  }
+  caseRef: string
+  fields: Record<string, string | string[] | null | number>
+  tags: string[]
+}
+
 const dynamicData: IDynamicData = {
   key: 'getCaseFields',
   name: 'Get Case Fields',
   async run($: IGlobalVariable): Promise<DynamicDataOutput> {
     try {
-      // This action only allows a step variable which we have to attempt to compute the parameter value, thinking if there is a better way to do this
-      // TODO: see if we can refresh the case fields from the API instead of using the cached data because right now, the user has to manually refresh the case fields to get the latest data
-      const { caseUuid } = $.step.parameters
-      if (!caseUuid) {
-        return {
-          data: [],
-        }
-      }
-
-      const priorExecutionSteps = await ExecutionStep.query().where({
-        execution_id: $.flow.testExecutionId,
-        status: 'success',
-      })
-
-      const computedParameters = computeParameters(
-        $.step.parameters,
-        priorExecutionSteps,
-      )
-      const computedCaseUuid = computedParameters.caseUuid as string
-
-      const { data: responseData } = await $.http.get(`/cases/:caseUuid`, {
-        urlPathParams: {
-          caseUuid: computedCaseUuid,
-        },
+      const { data: searchResult } = await $.http.post<{
+        traceId: string
+        total: number
+        data: GatherSGCase[]
+      }>('/cases/search', {
+        page: 1,
+        size: 1,
+        sort: 'createdAt',
+        order: 'desc',
       })
 
-      if (!responseData?.data) {
+      /**
+       * No cases found
+       */
+      if (searchResult.data.length === 0) {
         return {
           data: [],
         }
       }
 
-      const caseFields: object = responseData.data.fields
+      const caseFields: object = searchResult.data[0].fields
       const updatedCaseFields: { name: string; value: string }[] = []
       for (const [field, value] of Object.entries(caseFields)) {
         // Right now, we cannot support adding of array of objects as a value so just going to exclude to not cause errors unnecessarily
@@ -87,7 +91,7 @@ const dynamicData: IDynamicData = {
 
       return {
         data: [],
-        error: error?.message || 'Unknown error',
+        error: error?.message || error?.code || 'Unknown error',
       }
     }
   },

packages/backend/src/helpers/global-variable.ts

@@ -72,7 +72,6 @@ const globalVariable = async (
       userId: flow?.userId,
       hasFileProcessingActions:
         (await flow?.containsFileProcessingActions()) ?? false,
-      testExecutionId: flow?.testExecutionId,
     },
     step: {
       id: step?.id,

packages/frontend/src/components/MultiRow/index.tsx

@@ -106,7 +106,12 @@ function MultiRow(props: MultiRowProps): JSX.Element {
             {actualRows.map((row, index) => {
               const namePrefix = `${name}.${index}`
               return (
-                <Flex key={row.id} flexDir="column" gap={4} mb={4}>
+                <Flex
+                  key={`${row.id}-${index}`}
+                  flexDir="column"
+                  gap={4}
+                  mb={4}
+                >
                   {type === 'multirow-multicol' ? (
                     <>
                       <MultiCol

packages/types/index.d.ts

@@ -859,7 +859,6 @@ export type IGlobalVariable = {
     userId: string
     remoteWebhookId?: string
     setRemoteWebhookId?: (remoteWebhookId: string) => Promise<void>
-    testExecutionId: string
   }
   step?: {
     id: string