[REMOCK-1] PLU-471: remove GetStepWithTestExecutions and ExecuteFlow, remove single step testing killswitch (#1054)

## House-keeping PR

- Removed the `executeFlow` mutation resolver and its implementation
- Removed the `getStepWithTestExecutions` query which was already marked as deprecated
- Removed the `SINGLE_STEP_TEST_KILL_SWITCH` feature flag as it's no longer needed

### How to test?

1. Verify that step testing still works correctly in the editor
2. Confirm that test execution steps are properly displayed
3. Ensure that step execution status updates correctly after testing

Author: pregnantboy

packages/backend/src/graphql/mutation-resolvers.ts

@@ -10,7 +10,6 @@ import deleteFlow from './mutations/delete-flow'
 import deleteStep from './mutations/delete-step'
 import deleteUploadedFile from './mutations/delete-uploaded-file'
 import duplicateFlow from './mutations/duplicate-flow'
-import executeFlow from './mutations/execute-flow'
 import executeStep from './mutations/execute-step'
 import generateAuthUrl from './mutations/generate-auth-url'
 import generatePresignedUrl from './mutations/generate-presigned-url'
@@ -63,7 +62,6 @@ export default {
   updateFlow,
   updateFlowStatus,
   updateFlowConfig,
-  executeFlow,
   executeStep,
   deleteFlow,
   createStep,

packages/backend/src/graphql/mutations/execute-flow.ts

@@ -7,7 +7,7 @@ const getTestExecutionSteps: QueryResolvers['getTestExecutionSteps'] = async (
   params,
   context,
 ) => {
-  const { flowId, ignoreTestExecutionId } = params
+  const { flowId } = params
   // For checking if flow belongs to the user
   const flow = await context.currentUser
     .$relatedQuery('flows')
@@ -17,10 +17,7 @@ const getTestExecutionSteps: QueryResolvers['getTestExecutionSteps'] = async (
     .findById(flowId)
     .throwIfNotFound()
 
-  const testExecutionSteps = await getTestExecutionStepsHelper(
-    flow.id,
-    ignoreTestExecutionId,
-  )
+  const testExecutionSteps = await getTestExecutionStepsHelper(flow.id)
 
   // We do not return test execution steps if the step is not complete
   // to ensure we dont show variables from other step/events.

packages/backend/src/graphql/queries/get-step-with-test-executions.ts

@@ -12,7 +12,6 @@ import getFlowTransferDetails from './queries/get-flow-transfer-details'
 import getFlows from './queries/get-flows'
 import getPendingFlowTransfers from './queries/get-pending-flow-transfers'
 import getPlumberStats from './queries/get-plumber-stats'
-import getStepWithTestExecutions from './queries/get-step-with-test-executions'
 import getTemplates from './queries/get-templates'
 import getTestExecutionSteps from './queries/get-test-execution-steps'
 import healthcheck from './queries/healthcheck'
@@ -37,7 +36,6 @@ export default {
   testConnection,
   getFlow,
   getFlows,
-  getStepWithTestExecutions,
   getTestExecutionSteps,
   getExecution,
   getExecutions,

packages/backend/src/graphql/queries/get-test-execution-steps.ts

@@ -15,8 +15,6 @@ type Query {
     connectionId: String
     name: String
   ): PaginatedFlows
-  getStepWithTestExecutions(stepId: String!): [Step]
-    @deprecated(reason: "Use getTestExecution instead")
   getTestExecutionSteps(
     flowId: String!
     ignoreTestExecutionId: Boolean
@@ -77,7 +75,6 @@ type Mutation {
   updateFlow(input: UpdateFlowInput): Flow
   updateFlowStatus(input: UpdateFlowStatusInput): Flow
   updateFlowConfig(input: UpdateFlowConfigInput): Flow
-  executeFlow(input: ExecuteFlowInput): ExecutionStep!
   executeStep(input: ExecuteStepInput): ExecutionStep!
   deleteFlow(input: DeleteFlowInput): Boolean
   createStep(input: CreateStepInput): Step
@@ -476,10 +473,6 @@ input UpdateFlowConfigInput {
   attachments: [FlowAttachmentsConfigInput]
 }
 
-input ExecuteFlowInput {
-  stepId: String!
-}
-
 input ExecuteStepInput {
   stepId: String!
 }

packages/backend/src/graphql/query-resolvers.ts

@@ -1,7 +1,6 @@
 import { beforeEach, describe, expect, it } from 'vitest'
 
 import Execution from '@/models/execution'
-import ExecutionStep from '@/models/execution-step'
 import Flow from '@/models/flow'
 import User from '@/models/user'
 
@@ -234,57 +233,5 @@ describe('get test execution steps', () => {
         testExecution2.executionSteps[1].id,
       ])
     })
-
-    it('should return the latest test execution steps if ignoreTestExecutionId is set to true', async () => {
-      const testExecution2 = await Execution.query().insertGraphAndFetch({
-        flowId: flow.id,
-        testRun: true,
-        executionSteps: [
-          {
-            stepId: flow.steps[0].id,
-            status: 'success',
-            dataOut: { someData: 'data' },
-          },
-          {
-            stepId: flow.steps[1].id,
-            status: 'success',
-            dataOut: { someData: 'data' },
-          },
-        ],
-      })
-      await flow.$query().patch({ testExecutionId: testExecution1.id })
-      const testExecutionSteps = await getTestExecutionSteps(flow.id, true)
-      expect(testExecutionSteps).to.toHaveLength(3)
-      expect(testExecutionSteps.map((step) => step.id)).toEqual([
-        testExecution2.executionSteps[0].id,
-        testExecution2.executionSteps[1].id,
-        testExecution1.executionSteps[2].id,
-      ])
-    })
-
-    it('should return the latest test execution steps if more than 1 found for a step', async () => {
-      const dupes = await ExecutionStep.query().insert([
-        {
-          executionId: testExecution1.id,
-          stepId: flow.steps[0].id,
-          status: 'success',
-          dataOut: { someData: 'data' },
-        },
-        {
-          executionId: testExecution1.id,
-          stepId: flow.steps[1].id,
-          status: 'success',
-          dataOut: { someData: 'data' },
-        },
-      ])
-      await flow.$query().patch({ testExecutionId: testExecution1.id })
-      const testExecutionSteps = await getTestExecutionSteps(flow.id, true)
-      expect(testExecutionSteps).to.toHaveLength(3)
-      expect(testExecutionSteps.map((step) => step.id)).toEqual([
-        dupes[0].id,
-        dupes[1].id,
-        testExecution1.executionSteps[2].id,
-      ])
-    })
   })
 })

packages/backend/src/graphql/schema.graphql

@@ -5,7 +5,6 @@ import Flow from '@/models/flow'
 
 export async function getTestExecutionSteps(
   flowId: string,
-  ignoreTestExecutionId = false,
 ): Promise<ExecutionStep[]> {
   const flow = await Flow.query()
     .findById(flowId)
@@ -23,7 +22,7 @@ export async function getTestExecutionSteps(
     return []
   }
 
-  if (flow.testExecution && !ignoreTestExecutionId) {
+  if (flow.testExecution) {
     const testExecutionSteps = flow.testExecution.executionSteps
 
     /**

packages/backend/src/helpers/__tests__/get-test-execution-steps.itest.ts

@@ -7,8 +7,6 @@
 export const BANNER_TEXT_FLAG = 'banner_display'
 // we only want to show this notification to users created before this date (ms since epoch)
 export const SINGLE_STEP_TEST_SHOW_BEFORE_FLAG = 'single_step_test_show_before'
-// kill-switch for single-step testing in case of issues
-export const SINGLE_STEP_TEST_KILL_SWITCH = 'single_step_test_kill_switch'
 
 /**
  * Feature flags