[MRF-1] PLU-520: allow mrf forms to be connected

[pregnantboy]

feat: allow mrf check when connecting forms

Changes

• Removed checks for MRF forms
• Added MRF prefix to form names in the connection list

Refactors

• Refactored fetching form schema to it's own function

To test

• Should be able to connect an MRF form and test step

[pregnantboy]

• [MRF-8] PLU-520: New Approve-Reject component (frontend) #1284 : 2 dependent PRs (#1285 , #1349 )
• [MRF-7] PLU-520: remove mrf actions steps if necessary #1275
• [MRF-6] PLU-520: testStep for mrf actions should test multiple steps #1269
• [MRF-5] PLU-520: refactor frontend to allow test step on mrf actions #1268
• [MRF-4] PLU-520: automatically create/delete/update mrf steps on check step #1267
• [MRF-3] PLU-520: introduce mrf action that cannot be added by user #1266
• [MRF-2] PLU-520: parse formsg workflow data + refactor #1265
• [MRF-1] PLU-520: allow mrf forms to be connected #1264 👈 (View in Graphite)
• mrf/trunk

This stack of pull requests is managed by Graphite. Learn more about stacking.

[linear]

PLU-520 MRF: Approvals

[datadog-opengovsg]

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 33302ac | Docs | Was this helpful? Give us feedback!}

[kevinkim-ogp]

faced this error when connecting both new and existing MRF forms:

seems to be caused by formDetails.form.payments_field returning undefined

can be fixed by adding the optional chaining at lines 197-200 in packages/backend/src/apps/formsg/triggers/new-submission/get-mock-data.ts:

      ...(formDetails.form.payments_field?.enabled &&
        generateMockPaymentData(
          formDetails.form.payments_field?.products ?? [],
        )),

[kevinkim-ogp]

the error in the previous PR is actually fixed in the next PR. lgtm 👍
tested that:

• can connect MRF
• updated error message is shown for wrong form