Skip to content

Conversation

@pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Oct 15, 2025

Changes

  • Created a parseWorkflowData function to handle MRF workflow schema

Refactors

  • Refactored mock data generation:
    • Extracted patchMockData function from getMockData
    • Fetch form schema is now done before mock data generation

How to test?

  • No change in functionaility here, should still be able to connectio MRF + non-MRF forms

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Oct 16, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0cd9f54 | Docs | Was this helpful? Give us feedback!

@pregnantboy pregnantboy changed the title feat: parse formsg workflow data + refactor [MRF-1] PLU-520: parse formsg workflow data + refactor Oct 16, 2025
@linear
Copy link

linear bot commented Oct 16, 2025

PLU-520 MRF: Approvals

@pregnantboy pregnantboy force-pushed the mrf/parse-workflow-data branch from 97d13e9 to 0cd9f54 Compare December 3, 2025 10:55
@pregnantboy pregnantboy force-pushed the mrf/allow-mrf-connection branch from 63fe548 to 33302ac Compare December 3, 2025 10:55
@pregnantboy pregnantboy marked this pull request as ready for review December 3, 2025 16:23
@pregnantboy pregnantboy requested a review from a team as a code owner December 3, 2025 16:24
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants