Skip to content

Conversation

@pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Oct 15, 2025

Changes

  • Created a new hidden action mrfSubmission for FormSG app that handles subsequent MRF submissions
  • Added validation to prevent users from creating or updating hidden actions
  • Updated GraphQL schema to include hiddenFromUser property for actions
  • Added a helper method in App model to find triggers or actions by key
  • Modified the frontend to filter out hidden actions from the UI

How to test?

  • Add step modal should not show FormSG action
  • Comment out the frontend filter, and try adding formsg action -> it should fail

What's not done?

  • Preventing reordering of hidden actions
  • Preventing deletion of hidden actions
  • Preventing step name change of hidden actions

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Oct 16, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c19785a | Docs | Was this helpful? Give us feedback!

@pregnantboy pregnantboy changed the title feat: introduce mrf action that cannot be added by user [MRF-3] PLU-520: introduce mrf action that cannot be added by user Oct 16, 2025
@linear
Copy link

linear bot commented Oct 16, 2025

PLU-520 MRF: Approvals

@pregnantboy pregnantboy force-pushed the mrf/user-hidden-action branch from 4421189 to e6b1458 Compare October 21, 2025 12:16
@pregnantboy pregnantboy force-pushed the mrf/parse-workflow-data branch from 9142e15 to 334af24 Compare October 21, 2025 12:16
@pregnantboy pregnantboy force-pushed the mrf/user-hidden-action branch from e6b1458 to 22cc826 Compare October 21, 2025 12:50
@pregnantboy pregnantboy force-pushed the mrf/user-hidden-action branch from 22cc826 to 5d916fe Compare October 22, 2025 06:36
@pregnantboy pregnantboy force-pushed the mrf/user-hidden-action branch from 5d916fe to 750102a Compare December 3, 2025 10:55
@pregnantboy pregnantboy force-pushed the mrf/parse-workflow-data branch from 97d13e9 to 0cd9f54 Compare December 3, 2025 10:55
@pregnantboy pregnantboy marked this pull request as ready for review December 3, 2025 16:24
@pregnantboy pregnantboy requested a review from a team as a code owner December 3, 2025 16:24
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
✅ cannot add or update hidden actions via UI or graphql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants