Skip to content

Conversation

@pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Oct 15, 2025

What changed?

  • Created a new function createMrfSteps
    • Handle creating of the new MRF steps on Check Step
    • It should handle deleting/updating and adding of MRF steps while maintaining positions of other steps
  • Updated the FormSG new submission trigger to detect multi-respondent forms and create the appropriate workflow steps

How to test?

  1. Create a new flow with a FormSG trigger connected to a multi-respondent form
  2. Verify that the MRF workflow steps are automatically created with the correct parameters
  3. Update the form's workflow and verify that the steps are updated accordingly
  4. Test different scenarios: adding new steps, removing steps, and updating existing steps

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Oct 16, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: cb6a565 | Docs | Was this helpful? Give us feedback!

@pregnantboy pregnantboy changed the title feat: automatically create/delete/update mrf steps on testRun [MRF-4] PLU-520: automatically create/delete/update mrf steps on testRun Oct 16, 2025
@linear
Copy link

linear bot commented Oct 16, 2025

PLU-520 MRF: Approvals

@pregnantboy pregnantboy force-pushed the mrf/auto-create-mrf-steps branch from b3a61b5 to 699647e Compare October 21, 2025 12:16
@pregnantboy pregnantboy force-pushed the mrf/user-hidden-action branch from 4421189 to e6b1458 Compare October 21, 2025 12:16
@pregnantboy pregnantboy force-pushed the mrf/auto-create-mrf-steps branch from 699647e to 5bb05ed Compare October 21, 2025 12:50
@pregnantboy pregnantboy force-pushed the mrf/user-hidden-action branch from e6b1458 to 22cc826 Compare October 21, 2025 12:50
@pregnantboy pregnantboy changed the title [MRF-4] PLU-520: automatically create/delete/update mrf steps on testRun [MRF-4] PLU-520: automatically create/delete/update mrf steps on check step Oct 21, 2025
@pregnantboy pregnantboy force-pushed the mrf/user-hidden-action branch from 22cc826 to 5d916fe Compare October 22, 2025 06:36
@pregnantboy pregnantboy force-pushed the mrf/auto-create-mrf-steps branch from 5bb05ed to 8f2e5d3 Compare October 22, 2025 06:36
@pregnantboy pregnantboy force-pushed the mrf/auto-create-mrf-steps branch from dfb3c6f to cb6a565 Compare December 3, 2025 15:34
@pregnantboy pregnantboy marked this pull request as ready for review December 3, 2025 16:24
@pregnantboy pregnantboy requested a review from a team as a code owner December 3, 2025 16:24
const formSchema = await fetchFormSchema($, formId)

if (formSchema.form.responseMode === 'multirespondent') {
const mrfWorkflowData = await parseWorkflowData($, formSchema)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: don't need await here

Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested and verified that these work!

  • MRF steps are created and inserted correctly
  • New MRF steps are added
    • Existing actions remain in the correct position
  • Deleted MRF steps are deleted
    • Existing actions are collapsed below previous MRF step
  • Updated MRF steps are updated
    • MRF step and existing actions remain in the correct position

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants