-
Notifications
You must be signed in to change notification settings - Fork 8
[MRF-4] PLU-520: automatically create/delete/update mrf steps on check step #1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mrf/user-hidden-action
Are you sure you want to change the base?
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3caa491 to
5394d1c
Compare
87d2de2 to
4421189
Compare
5394d1c to
b3a61b5
Compare
b3a61b5 to
699647e
Compare
4421189 to
e6b1458
Compare
699647e to
5bb05ed
Compare
e6b1458 to
22cc826
Compare
22cc826 to
5d916fe
Compare
5bb05ed to
8f2e5d3
Compare
8f2e5d3 to
dfb3c6f
Compare
dfb3c6f to
cb6a565
Compare
| const formSchema = await fetchFormSchema($, formId) | ||
|
|
||
| if (formSchema.form.responseMode === 'multirespondent') { | ||
| const mrfWorkflowData = await parseWorkflowData($, formSchema) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: don't need await here
kevinkim-ogp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, tested and verified that these work!
- MRF steps are created and inserted correctly
- New MRF steps are added
- Existing actions remain in the correct position
- Deleted MRF steps are deleted
- Existing actions are collapsed below previous MRF step
- Updated MRF steps are updated
- MRF step and existing actions remain in the correct position

What changed?
createMrfStepsHow to test?