Skip to content

Conversation

@pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Oct 16, 2025

Changes

  • MRF steps should use FormSGCheckAgainButton
  • onSaveAndTestStep should not try to save step if it's a hidden action

Refactors

  • Refactored addStaticSubsteps to only add testStep substep if there's no fields to modify
  • Added cache-first fetch policy to the ChooseConnectionSubstep to improve performance
  • Small refactor of Save + Check step buttons
  • Added isMrfStep flag to the step metadata to properly handle FormSG MRF submissions

How to test?

  1. Check step/Save button should render properly for all existing actions
  2. Check step should render for MRF actions
  3. Should be able to click Check step for MRF actions although not implemented yet

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Oct 16, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c151c9c | Docs | Was this helpful? Give us feedback!

@pregnantboy pregnantboy changed the title chore: refactor frontend to allow test step on mrf actions [MRF-5] PLU-520: refactor frontend to allow test step on mrf actions Oct 16, 2025
@linear
Copy link

linear bot commented Oct 16, 2025

PLU-520 MRF: Approvals

@pregnantboy pregnantboy force-pushed the mrf/auto-create-mrf-steps branch from b3a61b5 to 699647e Compare October 21, 2025 12:16
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step branch from 7a117c7 to 8cb389b Compare October 21, 2025 12:16
@pregnantboy pregnantboy force-pushed the mrf/auto-create-mrf-steps branch from 699647e to 5bb05ed Compare October 21, 2025 12:50
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step branch from 8cb389b to 81818f0 Compare October 21, 2025 12:50
@pregnantboy pregnantboy force-pushed the mrf/auto-create-mrf-steps branch from 5bb05ed to 8f2e5d3 Compare October 22, 2025 06:36
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step branch from 81818f0 to c54eabf Compare October 22, 2025 06:36
@pregnantboy pregnantboy force-pushed the mrf/auto-create-mrf-steps branch from 8f2e5d3 to dfb3c6f Compare December 3, 2025 10:55
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step branch from c54eabf to 6410a36 Compare December 3, 2025 10:55
@pregnantboy pregnantboy force-pushed the mrf/auto-create-mrf-steps branch from dfb3c6f to cb6a565 Compare December 3, 2025 15:34
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step branch from 6410a36 to c151c9c Compare December 3, 2025 15:34
@pregnantboy pregnantboy marked this pull request as ready for review December 3, 2025 16:24
@pregnantboy pregnantboy requested a review from a team as a code owner December 3, 2025 16:24
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
only have a small nit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants