-
Notifications
You must be signed in to change notification settings - Fork 8
[MRF-6] PLU-520: testStep for mrf actions should test multiple steps #1269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mrf/mrf-action-test-step
Are you sure you want to change the base?
[MRF-6] PLU-520: testStep for mrf actions should test multiple steps #1269
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
de97b7e to
a215012
Compare
7a117c7 to
8cb389b
Compare
a215012 to
65afc5d
Compare
8cb389b to
81818f0
Compare
65afc5d to
4b2292b
Compare
4b2292b to
6106387
Compare
81818f0 to
c54eabf
Compare
6106387 to
2c7e9ee
Compare
2c7e9ee to
9ac97bd
Compare
6410a36 to
c151c9c
Compare
9ac97bd to
56ae685
Compare
56ae685 to
4781dbc
Compare
| : await actionCommand.run($, metadata) | ||
| if (result) { | ||
| runResult = result | ||
| metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this metadata here?
may be missing something, but seems to be redundant
kevinkim-ogp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Check step and all fields appear with mock data message
- MRF steps are connected to the same connection id
- Check step with real submission 👈 can't check step with real submission data (if this is meant to be the case for this PR, can ignore this)
note for checking with real data: need to use formSgSdk.cryptoV3.decrypt for MRF

Changes
createMrfStepsshould replicate the connectionId for all steps createdrefactor
mockDataMsgfield from trigger instructions, hardcode on frontend insteadHow to test?
What's not done?