Skip to content

Conversation

@pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Oct 16, 2025

Changes

  • Modified execute-step to execute testRun for all MRF steps
  • Updated the action processing to properly handle metadata from MRF submissions
  • createMrfSteps should replicate the connectionId for all steps created

refactor

  • Created a schema validation for MRF workflow steps
  • Removed the mockDataMsg field from trigger instructions, hardcode on frontend instead

How to test?

  1. Connect an MRF form
  2. Click check step on any of the MRF steps, all fields should appear together with the mock data message
  3. Verify that all MRF steps are properly connected and share the same connection ID

What's not done?

  • Filtering only editable fields for each step

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Oct 16, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4781dbc | Docs | Was this helpful? Give us feedback!

@pregnantboy pregnantboy changed the title feat: testStep for mrf actions should test multiple steps [MRF-6] PLU-520: testStep for mrf actions should test multiple steps Oct 16, 2025
@linear
Copy link

linear bot commented Oct 16, 2025

PLU-520 MRF: Approvals

@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step-backend branch from de97b7e to a215012 Compare October 21, 2025 12:16
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step branch from 7a117c7 to 8cb389b Compare October 21, 2025 12:16
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step-backend branch from a215012 to 65afc5d Compare October 21, 2025 12:50
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step branch from 8cb389b to 81818f0 Compare October 21, 2025 12:50
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step-backend branch from 65afc5d to 4b2292b Compare October 21, 2025 15:31
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step-backend branch from 4b2292b to 6106387 Compare October 22, 2025 02:52
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step branch from 81818f0 to c54eabf Compare October 22, 2025 06:36
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step-backend branch from 6106387 to 2c7e9ee Compare October 22, 2025 06:36
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step branch from 6410a36 to c151c9c Compare December 3, 2025 15:34
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step-backend branch from 9ac97bd to 56ae685 Compare December 3, 2025 15:35
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step-backend branch from 56ae685 to 4781dbc Compare December 3, 2025 15:45
@pregnantboy pregnantboy marked this pull request as ready for review December 3, 2025 16:24
@pregnantboy pregnantboy requested a review from a team as a code owner December 3, 2025 16:24
: await actionCommand.run($, metadata)
if (result) {
runResult = result
metadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this metadata here?
may be missing something, but seems to be redundant

Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Check step and all fields appear with mock data message
  • MRF steps are connected to the same connection id
  • Check step with real submission 👈 can't check step with real submission data (if this is meant to be the case for this PR, can ignore this)

note for checking with real data: need to use formSgSdk.cryptoV3.decrypt for MRF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants