Skip to content

Conversation

@pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Oct 22, 2025

Changes

  1. Adds functionality to remove MRF steps when a non-MRF form is connected
  2. Enhances the display of form fields:
    • Properly numbers questions in attachment answers
    • Hides header fields instead of collapsing them
    • Only shows editable fields in MRF steps (i.e. those fields that the form filler can edit at that pt of time)

The PR also includes tests to verify the new MRF step removal functionality.

@pregnantboy pregnantboy changed the base branch from mrf/mrf-action-test-step to graphite-base/1275 October 22, 2025 02:52
@pregnantboy pregnantboy changed the base branch from graphite-base/1275 to mrf/mrf-action-test-step-backend October 22, 2025 02:52
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step-backend branch from 6106387 to 2c7e9ee Compare October 22, 2025 06:36
@pregnantboy pregnantboy changed the title feat: testStep for mrf actions should test multiple steps [MRF-7] PLU-520: test step for mrf actions Nov 30, 2025
@linear
Copy link

linear bot commented Nov 30, 2025

PLU-520 MRF: Approvals

@pregnantboy pregnantboy changed the title [MRF-7] PLU-520: test step for mrf actions [MRF-7] PLU-520: remove mrf actions steps if necessary Nov 30, 2025
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step-backend branch from 2c7e9ee to 9ac97bd Compare December 3, 2025 10:55
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step-backend branch from 9ac97bd to 56ae685 Compare December 3, 2025 15:35
@pregnantboy pregnantboy force-pushed the mrf/mrf-action-test-step-backend branch from 56ae685 to 4781dbc Compare December 3, 2025 15:45
@pregnantboy pregnantboy marked this pull request as ready for review December 3, 2025 16:24
@pregnantboy pregnantboy requested a review from a team as a code owner December 3, 2025 16:24
if (questionIdsToShowForMrf && !questionIdsToShowForMrf.has(fieldId)) {
fieldMetadata[fieldId] = {
question: { isHidden: true },
answer: { isHidden: true },
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
answer: { isHidden: true },
answer: { isHidden: true },
answerArray: { isHidden: true },

think need to add for answerArray as well to handle checkboxes and tables

Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found some potential issues:

  1. Step name remains as MRF: xx after changing to a non-MRF form, may be better to rename back to 'New form submission' ?
  2. steps are not reordered properly after deleting MRF steps, but noticed that a resetStepOrdering function is introduced in the Step model in a subsequent PR. should it be introduced here?

other functionalities work as intended:

  • Attachment questions are numbered properly
  • Headers are hidden completely
  • Only shows editable fields in MRF steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants