-
Notifications
You must be signed in to change notification settings - Fork 8
[MRF-7] PLU-520: remove mrf actions steps if necessary #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mrf/mrf-action-test-step-backend
Are you sure you want to change the base?
[MRF-7] PLU-520: remove mrf actions steps if necessary #1275
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
55a34ec to
f9de870
Compare
6106387 to
2c7e9ee
Compare
f9de870 to
6a44877
Compare
2c7e9ee to
9ac97bd
Compare
6a44877 to
4ed9bf9
Compare
9ac97bd to
56ae685
Compare
4ed9bf9 to
888eb57
Compare
56ae685 to
4781dbc
Compare
888eb57 to
0f0a3fe
Compare
| if (questionIdsToShowForMrf && !questionIdsToShowForMrf.has(fieldId)) { | ||
| fieldMetadata[fieldId] = { | ||
| question: { isHidden: true }, | ||
| answer: { isHidden: true }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| answer: { isHidden: true }, | |
| answer: { isHidden: true }, | |
| answerArray: { isHidden: true }, |
think need to add for answerArray as well to handle checkboxes and tables
kevinkim-ogp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found some potential issues:
- Step name remains as
MRF: xxafter changing to a non-MRF form, may be better to rename back to 'New form submission' ? - steps are not reordered properly after deleting MRF steps, but noticed that a
resetStepOrderingfunction is introduced in theStepmodel in a subsequent PR. should it be introduced here?
other functionalities work as intended:
- Attachment questions are numbered properly
- Headers are hidden completely
- Only shows editable fields in MRF steps

Changes
The PR also includes tests to verify the new MRF step removal functionality.