-
Notifications
You must be signed in to change notification settings - Fork 8
[MRF-8] PLU-520: New Approve-Reject component (frontend) #1284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pregnantboy
wants to merge
1
commit into
mrf/remove-mrf-steps
Choose a base branch
from
mrf/mrf-approve-reject-select
base: mrf/remove-mrf-steps
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2025
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 24, 2025
6a44877 to
4ed9bf9
Compare
61a8fba to
1d60b1a
Compare
4ed9bf9 to
888eb57
Compare
1d60b1a to
453b89b
Compare
888eb57 to
0f0a3fe
Compare
453b89b to
317e3d3
Compare
kevinkim-ogp
approved these changes
Dec 8, 2025
Contributor
kevinkim-ogp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
-
isDeletablestill works as intended - Approve-Reject component is displayed correctly for approval steps
- Steps are created as intended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Changes
This PR adds UI elements for approval/rejection flow in FormSG MRF steps and includes several improvements:
createStepmutation to properly handle non-existent triggers/actionsisApprovalStepflaguseStepMetadatahookStepDisplayOverridescontext in favor ofuseStepMetadata