Skip to content

Conversation

@pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Oct 24, 2025

Changes

This PR adds UI elements for approval/rejection flow in FormSG MRF steps and includes several improvements:

  • Added an "If approved/If rejected" toggle UI component for FormSG MRF steps with approval fields
  • Fixed a bug in createStep mutation to properly handle non-existent triggers/actions
  • Refactored step metadata handling to improve code organization:
    • Moved FormSG-specific constants to a dedicated helper file
    • Improved step metadata detection with isApprovalStep flag
    • Consolidated step deletion logic into the useStepMetadata hook
  • Removed the StepDisplayOverrides context in favor of useStepMetadata

@linear
Copy link

linear bot commented Nov 30, 2025

PLU-520 MRF: Approvals

@pregnantboy pregnantboy force-pushed the mrf/mrf-approve-reject-select branch from 453b89b to 317e3d3 Compare December 3, 2025 15:45
@pregnantboy pregnantboy marked this pull request as ready for review December 3, 2025 16:24
@pregnantboy pregnantboy requested a review from a team as a code owner December 3, 2025 16:24
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

  • isDeletable still works as intended
  • Approve-Reject component is displayed correctly for approval steps
  • Steps are created as intended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants