Skip to content

[MRF-10] PLU-520: pass prevStep instead of prevStepId #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pregnantboy wants to merge 1 commit into
base: mrf/add-mrf-context-and-refactor
Choose a base branch
from
Open

[MRF-10] PLU-520: pass prevStep instead of prevStepId #1286

pregnantboy wants to merge 1 commit into from
+41 −33

Conversation

@pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Oct 26, 2025 •
edited
Loading

Changes

  • Changed AddStepButton component to accept a full step object instead of just stepId
  • Updated FlowStepConfigurationContext and related components to use prevStep instead of prevStepId
  • Enhanced MrfContext to include mrfApprovalSteps which filters steps with approval fields

@pregnantboy Graphite App
Copy link
Contributor Author

pregnantboy commented Oct 26, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Oct 26, 2025
Open
Closed
Open
Open
Open
Open
Open
This was referenced Nov 26, 2025
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@pregnantboy pregnantboy force-pushed the mrf/refactor-prevstep-id branch from f3251cf to 48a8bb2 Compare November 30, 2025 08:19
@pregnantboy pregnantboy changed the title refactor: use prevStep instead of prevStepId [MRF-10] PLU-520: pass prevStep instead of prevStepId Nov 30, 2025
@linear
Copy link

linear bot commented Nov 30, 2025

PLU-520 MRF: Approvals

@pregnantboy pregnantboy force-pushed the mrf/refactor-prevstep-id branch from 48a8bb2 to c8ba55d Compare November 30, 2025 09:12
@pregnantboy pregnantboy mentioned this pull request Nov 30, 2025
Open
@pregnantboy pregnantboy force-pushed the mrf/refactor-prevstep-id branch from c8ba55d to f9b6785 Compare December 3, 2025 10:55
@pregnantboy pregnantboy force-pushed the mrf/add-mrf-context-and-refactor branch 2 times, most recently from 8ef3dc5 to c27ebd0 Compare December 3, 2025 15:42
@pregnantboy pregnantboy force-pushed the mrf/refactor-prevstep-id branch from f9b6785 to 662ea8c Compare December 3, 2025 15:42
@pregnantboy pregnantboy force-pushed the mrf/refactor-prevstep-id branch from 662ea8c to 5188478 Compare December 3, 2025 15:45
@pregnantboy pregnantboy force-pushed the mrf/add-mrf-context-and-refactor branch from c27ebd0 to 3374fde Compare December 3, 2025 15:45
@pregnantboy pregnantboy marked this pull request as ready for review December 3, 2025 16:24
@pregnantboy pregnantboy requested a review from a team as a code owner December 3, 2025 16:24
kevinkim-ogp
kevinkim-ogp approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinkim-ogp kevinkim-ogp kevinkim-ogp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pregnantboy @kevinkim-ogp