Skip to content

[MRF-11] PLU-520: (backend) create step approval config #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pregnantboy wants to merge 3 commits into
base: mrf/refactor-prevstep-id
Choose a base branch
from
Open

[MRF-11] PLU-520: (backend) create step approval config #1287

pregnantboy wants to merge 3 commits into from

Conversation

@pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Oct 26, 2025 •
edited
Loading

No description provided.

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Oct 26, 2025 •
edited
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c9abe1b | Docs | Was this helpful? Give us feedback!

@pregnantboy Graphite App
Copy link
Contributor Author

pregnantboy commented Oct 26, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Oct 26, 2025
Open
Open
Closed
Open
@pregnantboy pregnantboy force-pushed the mrf/create-step-approval-config-backend branch from 8b56f58 to 9a17c6a Compare October 27, 2025 07:38
This was referenced Oct 27, 2025
Open
Open
Open
This was referenced Nov 26, 2025
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@pregnantboy pregnantboy force-pushed the mrf/refactor-prevstep-id branch from f3251cf to 48a8bb2 Compare November 30, 2025 08:19
@pregnantboy pregnantboy force-pushed the mrf/create-step-approval-config-backend branch from 6da876b to 00955cc Compare November 30, 2025 08:19
@pregnantboy pregnantboy force-pushed the mrf/refactor-prevstep-id branch from 48a8bb2 to c8ba55d Compare November 30, 2025 09:12
@pregnantboy pregnantboy changed the title feat(backend): set approval config in createStep mutation [MRF-11] PLU-520: set approval config when creating step Nov 30, 2025
@linear
Copy link

linear bot commented Nov 30, 2025

PLU-520 MRF: Approvals

@pregnantboy pregnantboy changed the title [MRF-11] PLU-520: set approval config when creating step [MRF-11] PLU-520: (backend) create step approval config Nov 30, 2025
@pregnantboy pregnantboy force-pushed the mrf/create-step-approval-config-backend branch from 00955cc to daa7ee4 Compare November 30, 2025 09:19
@pregnantboy pregnantboy changed the base branch from mrf/refactor-prevstep-id to graphite-base/1287 November 30, 2025 09:27
@pregnantboy pregnantboy mentioned this pull request Nov 30, 2025
Open
@pregnantboy pregnantboy force-pushed the mrf/create-step-approval-config-backend branch from daa7ee4 to dd2c20b Compare November 30, 2025 09:36
@pregnantboy pregnantboy force-pushed the mrf/create-step-approval-config-backend branch from dd2c20b to 095fd40 Compare December 3, 2025 10:55
@pregnantboy pregnantboy changed the base branch from graphite-base/1287 to mrf/refactor-prevstep-id December 3, 2025 10:56
@pregnantboy pregnantboy force-pushed the mrf/refactor-prevstep-id branch from f9b6785 to 662ea8c Compare December 3, 2025 15:42
@pregnantboy pregnantboy force-pushed the mrf/create-step-approval-config-backend branch from 095fd40 to a5ab6a4 Compare December 3, 2025 15:42
@pregnantboy pregnantboy force-pushed the mrf/create-step-approval-config-backend branch from a5ab6a4 to a707219 Compare December 3, 2025 15:45
@pregnantboy pregnantboy force-pushed the mrf/refactor-prevstep-id branch from 662ea8c to 5188478 Compare December 3, 2025 15:45
@pregnantboy pregnantboy force-pushed the mrf/create-step-approval-config-backend branch from a707219 to c9abe1b Compare December 3, 2025 16:09
@pregnantboy pregnantboy marked this pull request as ready for review December 3, 2025 16:24
@pregnantboy pregnantboy requested a review from a team as a code owner December 3, 2025 16:24
kevinkim-ogp
kevinkim-ogp reviewed Dec 9, 2025
View reviewed changes
packages/frontend/src/graphql/mutations/create-step.ts
}
config {
stepName
templateConfig {
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clarification: do we need to add the templateConfig?
don't think we add this in any of the createStep mutations

kevinkim-ogp
kevinkim-ogp approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinkim-ogp kevinkim-ogp kevinkim-ogp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pregnantboy @kevinkim-ogp