-
Notifications
You must be signed in to change notification settings - Fork 8
[MRF-12] PLU-520: (frontend) set approval config when creating step #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pregnantboy
wants to merge
3
commits into
mrf/create-step-approval-config-backend
Choose a base branch
from
mrf/create-step-approval-config-frontend
base: mrf/create-step-approval-config-backend
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[MRF-12] PLU-520: (frontend) set approval config when creating step #1288
pregnantboy
wants to merge
3
commits into
mrf/create-step-approval-config-backend
from
mrf/create-step-approval-config-frontend
+215
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This was referenced Oct 26, 2025
14cac82 to
4239c86
Compare
4239c86 to
be36007
Compare
This was referenced Oct 27, 2025
This was referenced Nov 26, 2025
be36007 to
0b79932
Compare
6da876b to
00955cc
Compare
653e5cc to
f8949a9
Compare
00955cc to
daa7ee4
Compare
daa7ee4 to
dd2c20b
Compare
b7008d8 to
0b32162
Compare
095fd40 to
a5ab6a4
Compare
0b32162 to
6596a49
Compare
a5ab6a4 to
a707219
Compare
6596a49 to
9cc1d84
Compare
a707219 to
c9abe1b
Compare
9cc1d84 to
642929c
Compare
kevinkim-ogp
reviewed
Dec 9, 2025
| const onDuplicateStep = useCallback(async () => { | ||
| const duplicateConfig = { | ||
| ...(step.config?.approval && { | ||
| approval: step.config?.approval, |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| approval: step.config?.approval, | |
| approval: { | |
| branch: step.config.approval.branch, | |
| stepId: step.config.approval.stepId, | |
| }, |
current config throws error when attempting to duplicate step in the 'reject' branch. it complains about __typename being present in the input
kevinkim-ogp
reviewed
Dec 9, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Changes
getMrfApprovalConfigto determine approval configuration for new stepsuseStepMetadatahook to detect and provide approval branch informationHow to test?