Skip to content

Conversation

@pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Oct 27, 2025

Changes

  • Added flowId field to the Step type in GraphQL schema
  • Removed manual flow ID population in the frontend Editor component
  • Simplified step creation and duplication by:
    • Replacing manual cache update handlers with Apollo's refetchQueries
    • Added removeTypenameFromVariables Apollo link to prevent validation errors
    • Fixed conditional approval config handling to avoid sending empty objects
  • Improved GraphQL queries to include necessary fields like flowId and createdAt

Copy link
Contributor Author

pregnantboy commented Oct 27, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Oct 27, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b7e7415 | Docs | Was this helpful? Give us feedback!

@pregnantboy pregnantboy force-pushed the mrf/refactor-create-step branch from c2ba285 to c1aa32f Compare October 27, 2025 10:44
@pregnantboy pregnantboy force-pushed the mrf/refactor-create-step branch from c1aa32f to 7758150 Compare November 26, 2025 09:20
@pregnantboy pregnantboy force-pushed the mrf/refactor-create-step branch from 7758150 to 91123ae Compare November 29, 2025 16:30
@pregnantboy pregnantboy force-pushed the mrf/create-step-approval-config-frontend branch 2 times, most recently from 0b79932 to 653e5cc Compare November 30, 2025 08:19
@pregnantboy pregnantboy force-pushed the mrf/refactor-create-step branch 2 times, most recently from 5578bf8 to 36e484e Compare November 30, 2025 09:19
@pregnantboy pregnantboy force-pushed the mrf/create-step-approval-config-frontend branch from 653e5cc to f8949a9 Compare November 30, 2025 09:19
@pregnantboy pregnantboy changed the title refactor(frontend): fetch flowId directly from backend, remove manual cache manipulation for createStep and duplicate step [MRF-13] PLU-520: (frontend) refactor cache manipulation Nov 30, 2025
@linear
Copy link

linear bot commented Nov 30, 2025

PLU-520 MRF: Approvals

@pregnantboy pregnantboy force-pushed the mrf/create-step-approval-config-frontend branch from f8949a9 to b7008d8 Compare November 30, 2025 09:44
@pregnantboy pregnantboy force-pushed the mrf/refactor-create-step branch 2 times, most recently from de041df to aef16f2 Compare December 3, 2025 10:55
@pregnantboy pregnantboy force-pushed the mrf/create-step-approval-config-frontend branch from 0b32162 to 6596a49 Compare December 3, 2025 15:42
@pregnantboy pregnantboy force-pushed the mrf/refactor-create-step branch from aef16f2 to 6e177e5 Compare December 3, 2025 15:42
@pregnantboy pregnantboy force-pushed the mrf/create-step-approval-config-frontend branch from 6596a49 to 9cc1d84 Compare December 3, 2025 15:45
@pregnantboy pregnantboy force-pushed the mrf/refactor-create-step branch from 6e177e5 to 86299bf Compare December 3, 2025 15:45
… cache manipulation for createStep and duplicate step
@pregnantboy pregnantboy force-pushed the mrf/refactor-create-step branch from 86299bf to b7e7415 Compare December 3, 2025 16:09
@pregnantboy pregnantboy force-pushed the mrf/create-step-approval-config-frontend branch from 9cc1d84 to 642929c Compare December 3, 2025 16:09
@pregnantboy pregnantboy marked this pull request as ready for review December 3, 2025 16:24
@pregnantboy pregnantboy requested a review from a team as a code owner December 3, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants