Skip to content

[MRF-14] PLU-520: (frontend) conditionally hide steps based on approval branch #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pregnantboy wants to merge 1 commit into
base: mrf/refactor-contexts
Choose a base branch
from
Open

[MRF-14] PLU-520: (frontend) conditionally hide steps based on approval branch #1293

pregnantboy wants to merge 1 commit into from
+167 −28

Conversation

@pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Oct 27, 2025 •
edited
Loading

Changes

  • Added visual indicators for approval/reject branches with appropriate colors (green for approve, red for reject) <-- this will change later
  • Modified the AddStepButton component to show colored dividers based on the approval branch
  • Created a new DisabledFlowStep component to display steps that are disabled due to conditional logic
  • Updated the workflow to hide steps that don't match the current approval branch selection
  • Show disabled MRF steps when a previous MRF step is rejected
  • Closes the drawer and deselects the current step when changing approval branches

This was referenced Oct 27, 2025
Open
Closed
Open
Open
Open
Open
@pregnantboy Graphite App
Copy link
Contributor Author

pregnantboy commented Oct 27, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pregnantboy pregnantboy mentioned this pull request Oct 27, 2025
Open
@pregnantboy pregnantboy force-pushed the mrf/conditionally-hide-steps branch from cbf6bb7 to d256379 Compare October 27, 2025 10:39
@pregnantboy pregnantboy force-pushed the mrf/refactor-contexts branch from 021e5c4 to 4215c69 Compare October 27, 2025 10:44
@pregnantboy pregnantboy force-pushed the mrf/conditionally-hide-steps branch 3 times, most recently from de55ba1 to 9377ab9 Compare October 28, 2025 13:20
@pregnantboy pregnantboy force-pushed the mrf/refactor-contexts branch from 4215c69 to cc22c20 Compare November 26, 2025 09:20
@pregnantboy pregnantboy force-pushed the mrf/conditionally-hide-steps branch from 9377ab9 to 5297ac0 Compare November 26, 2025 09:20
This was referenced Nov 26, 2025
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@pregnantboy pregnantboy force-pushed the mrf/refactor-contexts branch from cc22c20 to fc30efa Compare November 29, 2025 16:30
@pregnantboy pregnantboy force-pushed the mrf/conditionally-hide-steps branch 2 times, most recently from 619ded9 to c075a79 Compare November 30, 2025 08:19
@pregnantboy pregnantboy force-pushed the mrf/refactor-contexts branch from fc30efa to adc259d Compare November 30, 2025 08:19
@pregnantboy pregnantboy force-pushed the mrf/refactor-contexts branch from adc259d to fccf40b Compare November 30, 2025 08:56
@pregnantboy pregnantboy force-pushed the mrf/conditionally-hide-steps branch 2 times, most recently from 6c72d47 to a0e4fc5 Compare November 30, 2025 09:19
@pregnantboy pregnantboy force-pushed the mrf/refactor-contexts branch from fccf40b to 0c41ea2 Compare November 30, 2025 09:19
@pregnantboy pregnantboy mentioned this pull request Nov 30, 2025
Open
@pregnantboy pregnantboy changed the title feat: hide steps depending on approval branch [MRF-14] PLU-520: (frontend) conditionally hide steps Nov 30, 2025
@linear
Copy link

linear bot commented Nov 30, 2025

PLU-520 MRF: Approvals

@pregnantboy pregnantboy changed the title [MRF-14] PLU-520: (frontend) conditionally hide steps [MRF-14] PLU-520: (frontend) conditionally hide steps based on approval branch Nov 30, 2025
@pregnantboy pregnantboy force-pushed the mrf/conditionally-hide-steps branch from a0e4fc5 to 68454ce Compare November 30, 2025 09:44
@pregnantboy pregnantboy force-pushed the mrf/refactor-contexts branch from 0c41ea2 to 2482828 Compare November 30, 2025 09:44
@pregnantboy pregnantboy force-pushed the mrf/conditionally-hide-steps branch from 68454ce to c678ba5 Compare November 30, 2025 10:53
@pregnantboy pregnantboy force-pushed the mrf/refactor-contexts branch from 2482828 to de2b674 Compare December 3, 2025 10:55
@pregnantboy pregnantboy force-pushed the mrf/conditionally-hide-steps branch 2 times, most recently from 68625c8 to c404104 Compare December 3, 2025 15:42
@pregnantboy pregnantboy force-pushed the mrf/refactor-contexts branch from de2b674 to ad8d078 Compare December 3, 2025 15:42
@pregnantboy pregnantboy force-pushed the mrf/conditionally-hide-steps branch from c404104 to 81fa8dc Compare December 3, 2025 15:45
@pregnantboy pregnantboy force-pushed the mrf/refactor-contexts branch from ad8d078 to 4404d93 Compare December 3, 2025 15:45
@pregnantboy pregnantboy force-pushed the mrf/conditionally-hide-steps branch from 81fa8dc to fd80e73 Compare December 3, 2025 16:09
@pregnantboy pregnantboy force-pushed the mrf/refactor-contexts branch from 4404d93 to e390d43 Compare December 3, 2025 16:09
@pregnantboy pregnantboy marked this pull request as ready for review December 3, 2025 16:24
@pregnantboy pregnantboy requested a review from a team as a code owner December 3, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pregnantboy