[MRF-9] PLU-520: MRF context and refactor #1349
Open
+313
−240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 30, 2025
Contributor
Author
pregnantboy
changed the title
pregnantboy
force-pushed
the
mrf/add-mrf-context-and-refactor
branch
2 times, most recently
from
8ef3dc5 to
c27ebd0
Compare
^ Conflicts: ^ packages/frontend/src/components/EditorRightDrawer/Step.tsx
pregnantboy
force-pushed
the
mrf/add-mrf-context-and-refactor
branch
from
c27ebd0 to
3374fde
Compare
pregnantboy
force-pushed
the
mrf/mrf-approve-reject-select
branch
from
453b89b to
317e3d3
Compare
kevinkim-ogp
reviewed
Dec 9, 2025
| isMobile, | ||
| isDrawerOpen, | ||
| ) | ||
| } = useStepMetadata(step, true) |
Contributor
There was a problem hiding this comment.
if set to true, the drag handle will be shown for the for-each step. just a display issue, as its still not actually draggable
Suggested change
| } = useStepMetadata(step, true) | |
| } = useStepMetadata(step, allowReorder) |
kevinkim-ogp
reviewed
Dec 9, 2025
| isNested={isNested} | ||
| // only allow reordering if there are more than 1 action steps | ||
| allowReorder={nonIfThenActionSteps.length > 1} | ||
| allowReorder={true} |
Contributor
There was a problem hiding this comment.
Suggested change
| allowReorder={true} | |
| allowReorder={allowReorder} |
setting this to always be true will show the drag handle when there is nothing to drag. no real impact, just a display thing.
kevinkim-ogp
reviewed
Dec 9, 2025
| stepsBeforeGroup: IStep[] | ||
| groupedSteps: IStep[][] | ||
| showAddButton?: boolean | ||
| addButtonProps: { |
Contributor
There was a problem hiding this comment.
Suggested change
| addButtonProps: { | |
| allowReorder?: boolean, | |
| addButtonProps: { |
kevinkim-ogp
reviewed
Dec 9, 2025
| stepsBeforeGroup, | ||
| groupedSteps, | ||
| showAddButton = true, | ||
| addButtonProps: { |
Contributor
There was a problem hiding this comment.
Suggested change
| addButtonProps: { | |
| allowReorder = true, | |
| addButtonProps: { |
kevinkim-ogp
reviewed
Dec 9, 2025
| isLastStep={position === steps.length} | ||
| isNested={isNested} | ||
| stepsBeforeGroup={actionStepsBeforeGroup} | ||
| groupedSteps={groupedSteps} |
Contributor
There was a problem hiding this comment.
Suggested change
| groupedSteps={groupedSteps} | |
| groupedSteps={groupedSteps} | |
| allowReorder={nonIfThenActionSteps.length > 1} |
kevinkim-ogp
approved these changes
Dec 9, 2025
Contributor
kevinkim-ogp
left a comment
kevinkim-ogp
left a comment
There was a problem hiding this comment.
lgtm, tested and verified that all functionalities remain!
small thing that we may want to fix is to hide the drag handle when there is only 1 draggable action step. does not affect any functionality, pure UI thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
These changes make the code more maintainable and prepare for future form approval functionality.