Skip to content

feat: jwt sub #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhengzheng-jason merged 4 commits into from
Nov 20, 2025
Merged

feat: jwt sub #6

zhengzheng-jason merged 4 commits into from
Nov 20, 2025

Conversation

@zhengzheng-jason
Copy link
Contributor

@zhengzheng-jason zhengzheng-jason commented Nov 19, 2025 •
edited
Loading

Problem

We added JWT sub claim support in https://github.com/opengovsg/refer/pull/968. This PR implemented the signing logic in client SDK.

Closes REFX-622.

Solution

Added subject as an optional param in client initialization.

Tests

  • Published a dev version and tested in HAS local env for the below cases:
    • only iss
    • iss with valid sub
    • iss with invalid sub

Deploy Notes

NA

@linear
Copy link

linear bot commented Nov 19, 2025

REFX-622 Add `sub` into SDK JWT signing logic

@zhengzheng-jason zhengzheng-jason marked this pull request as ready for review November 19, 2025 07:17
@zhengzheng-jason zhengzheng-jason merged commit bfa416b into master Nov 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shyamsundar2007 shyamsundar2007 shyamsundar2007 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhengzheng-jason @shyamsundar2007