feat: add rules API #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PrawiraGenestonlia
left a comment
PrawiraGenestonlia
left a comment
There was a problem hiding this comment.
left comments!
Contributor
PrawiraGenestonlia
left a comment
PrawiraGenestonlia
left a comment
There was a problem hiding this comment.
Can you also add test cases?
| } | ||
| return await response.json() | ||
| } catch (err) { | ||
| return Promise.reject((err as Error).message) |
Contributor
There was a problem hiding this comment.
Suggested change
| return Promise.reject((err as Error).message) | |
| throw new Error(err) |
| const response = await fetch(this.rulesEngineEndpoint, { | ||
| method: 'POST', | ||
| headers: { | ||
| 'Content-Type': 'application/x-www-form-urlencoded', |
Contributor
There was a problem hiding this comment.
Why are you using application/x-www-form-urlencoded instead of json?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the Rules API for TypeScript SDK users to calculate dynamic derived data.
Features:
rules()which sends a POST request to sgID Rules Engine server to retrieved the dynamic derived data.Improvements:
Before & After Screenshots
BEFORE:
AFTER:
Tests
Tested locally on an
sgid-test-appdraft PR vianpm pack.Deploy Notes
New dependencies:
"[email protected]": To make HTTP requests to sgID Rules Engine server.New dev dependencies:
@types/[email protected]: For TS typing.