[solaredge] Fix request lifecycle on failed HTTP responses

rogrun · rogrun · commit cc1757699bae · 2026-02-12T11:21:31.000+01:00
Signed-off-by: Ronny Grun &lt;ronny.grun@t-online.de&gt;
diff --git a/bundles/org.openhab.binding.solaredge/src/main/java/org/openhab/binding/solaredge/internal/command/AggregateDataUpdatePrivateApi.java b/bundles/org.openhab.binding.solaredge/src/main/java/org/openhab/binding/solaredge/internal/command/AggregateDataUpdatePrivateApi.java
@@ -102,7 +102,6 @@ public void onComplete(@Nullable Result result) {
         logger.debug("onComplete()");
 
         if (!HttpStatus.Code.OK.equals(getCommunicationStatus().getHttpCode())) {
-            updateListenerStatus();
             if (retries++ < MAX_RETRIES) {
                 handler.getWebInterface().enqueueCommand(this);
             }
@@ -116,5 +115,6 @@ public void onComplete(@Nullable Result result) {
                 }
             }
         }
+        updateListenerStatus();
     }
 }
diff --git a/bundles/org.openhab.binding.solaredge/src/main/java/org/openhab/binding/solaredge/internal/command/AggregateDataUpdatePublicApi.java b/bundles/org.openhab.binding.solaredge/src/main/java/org/openhab/binding/solaredge/internal/command/AggregateDataUpdatePublicApi.java
@@ -94,7 +94,6 @@ public void onComplete(@Nullable Result result) {
         logger.debug("onComplete()");
 
         if (!HttpStatus.Code.OK.equals(getCommunicationStatus().getHttpCode())) {
-            updateListenerStatus();
             if (retries++ < MAX_RETRIES) {
                 handler.getWebInterface().enqueueCommand(this);
             }
@@ -108,5 +107,6 @@ public void onComplete(@Nullable Result result) {
                 }
             }
         }
+        updateListenerStatus();
     }
 }
diff --git a/bundles/org.openhab.binding.solaredge/src/main/java/org/openhab/binding/solaredge/internal/command/LiveDataUpdateMeterless.java b/bundles/org.openhab.binding.solaredge/src/main/java/org/openhab/binding/solaredge/internal/command/LiveDataUpdateMeterless.java
@@ -63,7 +63,6 @@ public void onComplete(@Nullable Result result) {
         logger.debug("onComplete()");
 
         if (!HttpStatus.Code.OK.equals(getCommunicationStatus().getHttpCode())) {
-            updateListenerStatus();
             if (retries++ < MAX_RETRIES) {
                 handler.getWebInterface().enqueueCommand(this);
             }
@@ -77,5 +76,6 @@ public void onComplete(@Nullable Result result) {
                 }
             }
         }
+        updateListenerStatus();
     }
 }
diff --git a/bundles/org.openhab.binding.solaredge/src/main/java/org/openhab/binding/solaredge/internal/command/LiveDataUpdatePrivateApi.java b/bundles/org.openhab.binding.solaredge/src/main/java/org/openhab/binding/solaredge/internal/command/LiveDataUpdatePrivateApi.java
@@ -63,7 +63,6 @@ public void onComplete(@Nullable Result result) {
         logger.debug("onComplete()");
 
         if (!HttpStatus.Code.OK.equals(getCommunicationStatus().getHttpCode())) {
-            updateListenerStatus();
             if (retries++ < MAX_RETRIES) {
                 handler.getWebInterface().enqueueCommand(this);
             }
@@ -77,5 +76,6 @@ public void onComplete(@Nullable Result result) {
                 }
             }
         }
+        updateListenerStatus();
     }
 }
diff --git a/bundles/org.openhab.binding.solaredge/src/main/java/org/openhab/binding/solaredge/internal/command/LiveDataUpdatePublicApi.java b/bundles/org.openhab.binding.solaredge/src/main/java/org/openhab/binding/solaredge/internal/command/LiveDataUpdatePublicApi.java
@@ -62,7 +62,6 @@ protected String getURL() {
     public void onComplete(@Nullable Result result) {
         logger.debug("onComplete()");
         if (!HttpStatus.Code.OK.equals(getCommunicationStatus().getHttpCode())) {
-            updateListenerStatus();
             if (retries++ < MAX_RETRIES) {
                 handler.getWebInterface().enqueueCommand(this);
             }
@@ -76,5 +75,6 @@ public void onComplete(@Nullable Result result) {
                 }
             }
         }
+        updateListenerStatus();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,6 @@ public void onComplete(@Nullable Result result) {`
`102`	`102`	`logger.debug("onComplete()");`
`103`	`103`
`104`	`104`	`if (!HttpStatus.Code.OK.equals(getCommunicationStatus().getHttpCode())) {`
`105`		`- updateListenerStatus();`
`106`	`105`	`if (retries++ < MAX_RETRIES) {`
`107`	`106`	`handler.getWebInterface().enqueueCommand(this);`
`108`	`107`	`}`
`@@ -116,5 +115,6 @@ public void onComplete(@Nullable Result result) {`
`116`	`115`	`}`
`117`	`116`	`}`
`118`	`117`	`}`
	`118`	`+ updateListenerStatus();`
`119`	`119`	`}`
`120`	`120`	`}`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,6 @@ public void onComplete(@Nullable Result result) {`
`94`	`94`	`logger.debug("onComplete()");`
`95`	`95`
`96`	`96`	`if (!HttpStatus.Code.OK.equals(getCommunicationStatus().getHttpCode())) {`
`97`		`- updateListenerStatus();`
`98`	`97`	`if (retries++ < MAX_RETRIES) {`
`99`	`98`	`handler.getWebInterface().enqueueCommand(this);`
`100`	`99`	`}`
`@@ -108,5 +107,6 @@ public void onComplete(@Nullable Result result) {`
`108`	`107`	`}`
`109`	`108`	`}`
`110`	`109`	`}`
	`110`	`+ updateListenerStatus();`
`111`	`111`	`}`
`112`	`112`	`}`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,6 @@ public void onComplete(@Nullable Result result) {`
`63`	`63`	`logger.debug("onComplete()");`
`64`	`64`
`65`	`65`	`if (!HttpStatus.Code.OK.equals(getCommunicationStatus().getHttpCode())) {`
`66`		`- updateListenerStatus();`
`67`	`66`	`if (retries++ < MAX_RETRIES) {`
`68`	`67`	`handler.getWebInterface().enqueueCommand(this);`
`69`	`68`	`}`
`@@ -77,5 +76,6 @@ public void onComplete(@Nullable Result result) {`
`77`	`76`	`}`
`78`	`77`	`}`
`79`	`78`	`}`
	`79`	`+ updateListenerStatus();`
`80`	`80`	`}`
`81`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,6 @@ protected String getURL() {`
`62`	`62`	`public void onComplete(@Nullable Result result) {`
`63`	`63`	`logger.debug("onComplete()");`
`64`	`64`	`if (!HttpStatus.Code.OK.equals(getCommunicationStatus().getHttpCode())) {`
`65`		`- updateListenerStatus();`
`66`	`65`	`if (retries++ < MAX_RETRIES) {`
`67`	`66`	`handler.getWebInterface().enqueueCommand(this);`
`68`	`67`	`}`
`@@ -76,5 +75,6 @@ public void onComplete(@Nullable Result result) {`
`76`	`75`	`}`
`77`	`76`	`}`
`78`	`77`	`}`
	`78`	`+ updateListenerStatus();`
`79`	`79`	`}`
`80`	`80`	`}`